From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtMjB-0002mN-33
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 14:24:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtMj5-0003z9-7h
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 14:24:17 -0500
Received: from cantor2.suse.de ([195.135.220.15]:45263 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtMj5-0003z5-1V
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 14:24:11 -0500
Message-ID: <52B1F654.6060607@suse.de>
Date: Wed, 18 Dec 2013 20:24:04 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1383646565-13774-1-git-send-email-zxq_yx_007@163.com>
	<52B1E202.4070701@suse.de> <52B1E494.7080404@suse.de>
	<alpine.DEB.2.02.1312181919580.8667@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1312181919580.8667@kaball.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xiaoqiang zhao <zxq_yx_007@163.com>, Chen Fan <chen.fan.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com

Am 18.12.2013 20:20, schrieb Stefano Stabellini:
> On Wed, 18 Dec 2013, Andreas F=C3=A4rber wrote:
>> Am 18.12.2013 18:57, schrieb Andreas F=C3=A4rber:
>>> Am 05.11.2013 11:16, schrieb xiaoqiang zhao:
>>>> xiaoqiang zhao (4):
>>>>   apic: Cleanup for QOM'ify
>>>>   apic: QOM'ify apic & icc_bus
>>>>   ioapic: Cleanup for QOM'ify
>>>>   ioapic: QOM'ify ioapic
>>>
>>> Thanks, I have rebased and queued them with changes on qom-next:
>>> https://github.com/afaerber/qemu-cpu/commits/qom-next
>>>
>>> In particular I have reverted TYPE_ introductions were unnecessary an=
d
>>> reverted usages of TYPE_ constants for MemoryRegions. Also two white
>>> lines have been dropped. The ICC bus conversion has been split out as=
 a
>>> separate step, using NULL errp as intermediate step since ignored.
>>> (CC'ing Peter C. and Luiz)
>>
>> Oh and you forgot to convert the Xen APIC, I trivially fixed that.
>> (CC'ing Stefano)
>=20
> Yes, it should be really trivial. Give a look at hw/xen/xen_apic.c.

https://github.com/afaerber/qemu-cpu/commit/40ae2368c4c9135971c69fa680949=
b5b1cfa4410#diff-3

Just wanted to give you a heads-up that we're messing in your code. :)

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg