From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net,
Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: Re: [PATCH 1/2] intel_pstate: Add setting voltage value for baytrail P states.
Date: Wed, 18 Dec 2013 16:03:53 -0800 [thread overview]
Message-ID: <52B237E9.5050903@gmail.com> (raw)
In-Reply-To: <1445568.VWz2v5WUSg@amdc1032>
On 12/18/2013 04:37 AM, Bartlomiej Zolnierkiewicz wrote:
val |= (u64)1 << 32;
>> +
>> + vid_fp = mul_fp(cpudata->vid.min +
>> + int_tofp(pstate - cpudata->pstate.min_pstate),
>> + cpudata->vid.ratio);
>
> Shouldn't this be:
>
> + vid_fp = cpudata->vid.min + mul_fp(
> + int_tofp(pstate - cpudata->pstate.min_pstate),
> + cpudata->vid.ratio);
>
Yes thx
> ?
>
prev parent reply other threads:[~2013-12-19 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 17:42 [PATCH 1/2] intel_pstate: Add setting voltage value for baytrail P states dirk.brandewie
2013-12-17 17:42 ` [PATCH 2/2] intel_pstate: Remove periodic P state boost dirk.brandewie
2013-12-18 12:37 ` [PATCH 1/2] intel_pstate: Add setting voltage value for baytrail P states Bartlomiej Zolnierkiewicz
2013-12-19 0:03 ` Dirk Brandewie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B237E9.5050903@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.