From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rohit Vaswani Subject: Re: [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers Date: Wed, 18 Dec 2013 17:27:49 -0800 Message-ID: <52B24B95.8010004@codeaurora.org> References: <1386717544-478-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:60140 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872Ab3LSB1v (ORCPT ); Wed, 18 Dec 2013 20:27:51 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij , Stephen Boyd , Bjorn Andersson Cc: "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" On 12/12/2013 11:02 AM, Linus Walleij wrote: > On Wed, Dec 11, 2013 at 12:19 AM, Stephen Boyd = wrote: > >> We should be writing bits here but instead we're writing the >> numbers that correspond to the bits we want to write. Fix it by >> wrapping the numbers in the BIT() macro. This fixes gpios acting >> as interrupts. >> >> Signed-off-by: Stephen Boyd > I've applied this for fixes and tagged for stable. > Bj=F6rn, Rohit: OK? > > Yours, > Linus Walleij Acked-by: Rohit Vaswani Thanks, Rohit Vaswani --=20 The Qualcomm Innovation Center, Inc. is a member of the Code Aurora For= um, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 From: rvaswani@codeaurora.org (Rohit Vaswani) Date: Wed, 18 Dec 2013 17:27:49 -0800 Subject: [PATCH 1/2] gpio: msm: Fix irq mask/unmask by writing bits instead of numbers In-Reply-To: References: <1386717544-478-1-git-send-email-sboyd@codeaurora.org> Message-ID: <52B24B95.8010004@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/12/2013 11:02 AM, Linus Walleij wrote: > On Wed, Dec 11, 2013 at 12:19 AM, Stephen Boyd wrote: > >> We should be writing bits here but instead we're writing the >> numbers that correspond to the bits we want to write. Fix it by >> wrapping the numbers in the BIT() macro. This fixes gpios acting >> as interrupts. >> >> Signed-off-by: Stephen Boyd > I've applied this for fixes and tagged for stable. > Bj?rn, Rohit: OK? > > Yours, > Linus Walleij Acked-by: Rohit Vaswani Thanks, Rohit Vaswani -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation