From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH] audit: fix build error when disable audit Date: Thu, 19 Dec 2013 10:40:40 +0800 Message-ID: <52B25CA8.8090806@cn.fujitsu.com> References: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (ext-mx15.extmail.prod.ext.phx2.redhat.com [10.5.110.20]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBJ2fctJ021154 for ; Wed, 18 Dec 2013 21:41:38 -0500 Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84] (may be forged)) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJ2fWgE000402 for ; Wed, 18 Dec 2013 21:41:36 -0500 In-Reply-To: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Gao feng , linux-audit@redhat.com Cc: linux-kernel@vger.kernel.org List-Id: linux-audit@redhat.com T24gMTIvMTkvMjAxMyAxMDozNCBBTSwgR2FvIGZlbmcgd3JvdGU6Cj4ga2VybmVsL2NhcGFiaWxp dHkuYzogSW4gZnVuY3Rpb24g4oCYU1lTQ19jYXBzZXTigJk6Cj4ga2VybmVsL2NhcGFiaWxpdHku YzoyODA6Mjogd2FybmluZzogcGFzc2luZyBhcmd1bWVudCAxIG9mIOKAmGF1ZGl0X2xvZ19jYXBz ZXTigJkgbWFrZXMgaW50ZWdlciBmcm9tIHBvaW50ZXIgd2l0aG91dCBhIGNhc3QgW2VuYWJsZWQg YnkgZGVmYXVsdF0KPiAgIGF1ZGl0X2xvZ19jYXBzZXQobmV3LCBjdXJyZW50X2NyZWQoKSk7Cj4g ICBeCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIGtlcm5lbC9jYXBhYmlsaXR5LmM6MTA6MDoKPiBp bmNsdWRlL2xpbnV4L2F1ZGl0Lmg6NDAwOjIwOiBub3RlOiBleHBlY3RlZCDigJhwaWRfdOKAmSBi dXQgYXJndW1lbnQgaXMgb2YgdHlwZSDigJhzdHJ1Y3QgY3JlZCAq4oCZCj4gIHN0YXRpYyBpbmxp bmUgdm9pZCBhdWRpdF9sb2dfY2Fwc2V0KHBpZF90IHBpZCwgY29uc3Qgc3RydWN0IGNyZWQgKm5l dywKPiAgICAgICAgICAgICAgICAgICAgIF4KPiBrZXJuZWwvY2FwYWJpbGl0eS5jOjI4MDoyOiBl cnJvcjogdG9vIGZldyBhcmd1bWVudHMgdG8gZnVuY3Rpb24g4oCYYXVkaXRfbG9nX2NhcHNldOKA mQo+ICAgYXVkaXRfbG9nX2NhcHNldChuZXcsIGN1cnJlbnRfY3JlZCgpKTsKPiAgIF4KPiBJbiBm aWxlIGluY2x1ZGVkIGZyb20ga2VybmVsL2NhcGFiaWxpdHkuYzoxMDowOgo+IGluY2x1ZGUvbGlu dXgvYXVkaXQuaDo0MDA6MjA6IG5vdGU6IGRlY2xhcmVkIGhlcmUKPiAgc3RhdGljIGlubGluZSB2 b2lkIGF1ZGl0X2xvZ19jYXBzZXQocGlkX3QgcGlkLCBjb25zdCBzdHJ1Y3QgY3JlZCAqbmV3LAo+ ICAgICAgICAgICAgICAgICAgICAgXgo+IG1ha2VbMV06ICoqKiBba2VybmVsL2NhcGFiaWxpdHku b10gRXJyb3IgMQo+IAoKQlRXLCBidWcgaW50cm9kdWNlZCBieSBjb21tbWl0IDI2YjgxZWI0MDhj NDExZDg2YzdjYzkzMjc4ZmI4OGZiY2Q3ODVmNjUKYXVkaXQ6IFNpbXBsaWZ5IGFuZCBjb3JyZWN0 IGF1ZGl0X2xvZ19jYXBzZXQKCi0tCkxpbnV4LWF1ZGl0IG1haWxpbmcgbGlzdApMaW51eC1hdWRp dEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9saW51 eC1hdWRpdA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521Ab3LSCqx (ORCPT ); Wed, 18 Dec 2013 21:46:53 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:18912 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751239Ab3LSCqw convert rfc822-to-8bit (ORCPT ); Wed, 18 Dec 2013 21:46:52 -0500 X-IronPort-AV: E=Sophos;i="4.95,511,1384272000"; d="scan'208";a="9287858" Message-ID: <52B25CA8.8090806@cn.fujitsu.com> Date: Thu, 19 Dec 2013 10:40:40 +0800 From: Gao feng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Gao feng , linux-audit@redhat.com CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] audit: fix build error when disable audit References: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> In-Reply-To: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/12/19 10:39:10, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/12/19 10:39:10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/19/2013 10:34 AM, Gao feng wrote: > kernel/capability.c: In function ‘SYSC_capset’: > kernel/capability.c:280:2: warning: passing argument 1 of ‘audit_log_capset’ makes integer from pointer without a cast [enabled by default] > audit_log_capset(new, current_cred()); > ^ > In file included from kernel/capability.c:10:0: > include/linux/audit.h:400:20: note: expected ‘pid_t’ but argument is of type ‘struct cred *’ > static inline void audit_log_capset(pid_t pid, const struct cred *new, > ^ > kernel/capability.c:280:2: error: too few arguments to function ‘audit_log_capset’ > audit_log_capset(new, current_cred()); > ^ > In file included from kernel/capability.c:10:0: > include/linux/audit.h:400:20: note: declared here > static inline void audit_log_capset(pid_t pid, const struct cred *new, > ^ > make[1]: *** [kernel/capability.o] Error 1 > BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd785f65 audit: Simplify and correct audit_log_capset