All of lore.kernel.org
 help / color / mirror / Atom feed
From: Freddy Xin <freddy@asix.com.tw>
To: David Laight <David.Laight@ACULAB.COM>,
	netdev@vger.kernel.org, davem@davemloft.net,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	louis@asix.com.tw, allan@asix.com.tw
Subject: Re: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB.
Date: Thu, 19 Dec 2013 11:14:20 +0800	[thread overview]
Message-ID: <52B2648C.80500@asix.com.tw> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7490@saturn3.aculab.com>


On 2013年12月16日 18:09, David Laight wrote:
>> I was thinking of something like: skb = netdev_alloc_skb(dev, length 
>> + dev->skb_align, gfp); if (NET_IP_ALIGN && skb && !(ev->driver_flags 
>> & FLAG_HW_IPALIGN)) skb_reserve(skb, NET_IP_ALIGN); It might even be 
>> reasonable to remove the length adjustment - provided that all the 
>> later code uses the skb length. David 

Thanks for your advice.
In the way you advised, does the dev->skb_align equal
to NET_IP_ALIGN in the case that HW doesn't supoort
IP alignment?
In other words, dev->skb_align should be initialized to
NET_IP_ALIGN in USBNET, and I can change its value to
0 in AX88179_178A driver, right?

     Freddy


  reply	other threads:[~2013-12-19  3:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13  9:25 [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB freddy
2013-12-13 10:36 ` David Laight
2013-12-13 10:36   ` David Laight
2013-12-16  6:54   ` Freddy Xin
2013-12-16 10:09     ` David Laight
2013-12-16 10:09       ` David Laight
2013-12-19  3:14       ` Freddy Xin [this message]
2013-12-19 10:01         ` David Laight
2013-12-19 10:01           ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B2648C.80500@asix.com.tw \
    --to=freddy@asix.com.tw \
    --cc=David.Laight@ACULAB.COM \
    --cc=allan@asix.com.tw \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=louis@asix.com.tw \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.