All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT][PATCH 5/5] am43xx: add delay before xfer
Date: Thu, 19 Dec 2013 10:35:14 +0530	[thread overview]
Message-ID: <52B27E8A.8090102@ti.com> (raw)
In-Reply-To: <CAD6G_RTEFUbTRLuZZnzScd6TWykquHRH8rCsERgRpJRP8-g2jw@mail.gmail.com>

On Thursday 19 December 2013 12:17 AM, Jagan Teki wrote:
> On Thu, Nov 14, 2013 at 9:09 PM, Sourav Poddar<sourav.poddar@ti.com>  wrote:
>> Without this delay, write/read is failing.
>> Looks like, the WIP always remain set and hence a timeout
>> occurs leading to the error.
>>
>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>> ---
>> Hi Jagan,
>> This patch seems to be necessary for read/write.
>> I tested by changing few timing variables, but it did not help.
>> The same driver works on J6 with a differnet flash(S25FL256S).
>> Is any one tested macronix flash at uboot?
> Delay must be for macronix?
> or common for all flashes.
>
For macronix.
> I haven't tested macronix
>
>>   drivers/spi/ti_qspi.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
>> index 5666250..aa7b6ae 100644
>> --- a/drivers/spi/ti_qspi.c
>> +++ b/drivers/spi/ti_qspi.c
>> @@ -285,6 +285,9 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
>>                  qslave->cmd |= QSPI_3_PIN;
>>          qslave->cmd |= 0xfff;
>>
>> +#ifdef CONFIG_AM43XX
>> +       udelay(100);
>> +#endif
>>          while (words--) {
>>                  if (txp) {
>>                          debug("tx cmd %08x dc %08x data %02x\n",
>> --
>> 1.7.1
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>

  reply	other threads:[~2013-12-19  5:05 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 15:39 [U-Boot] [UBOOT][PATCH 0/5] qspi: Add AM437x support Sourav Poddar
2013-11-14 15:39 ` [U-Boot] [UBOOT][PATCH 1/5] am43xx: add qspi support Sourav Poddar
2013-11-14 15:39 ` [U-Boot] [UBOOT][PATCH 2/5] am437x_epos_evm: add SPL API, QSPI, and serial flash support Sourav Poddar
2013-11-14 15:39 ` [U-Boot] [UBOOT][PATCH 3/5] sf: macronix: Add support for MX66L51235F Sourav Poddar
2013-12-18 18:51   ` Jagan Teki
2013-12-19  5:03     ` Sourav Poddar
2013-12-19  5:52       ` Jagan Teki
2013-12-19  5:54         ` Sourav Poddar
2013-12-19  5:58           ` Jagan Teki
2013-11-14 15:39 ` [U-Boot] [UBOOT][PATCH 4/5] qspi/spi: Add AM43xx specifics changes Sourav Poddar
2013-11-14 15:39 ` [U-Boot] [UBOOT][PATCH 5/5] am43xx: add delay before xfer Sourav Poddar
2013-12-18 18:47   ` Jagan Teki
2013-12-19  5:05     ` Sourav Poddar [this message]
2013-12-19  5:54       ` Jagan Teki
2013-12-19  5:54         ` Sourav Poddar
2013-12-19  6:07           ` Jagan Teki
2013-11-15  4:39 ` [U-Boot] [UBOOT][PATCH 0/5] qspi: Add AM437x support Sourav Poddar
2013-11-25 10:58 ` Sourav Poddar
2013-12-19  6:54   ` Jagan Teki
2013-12-19  7:07     ` Sourav Poddar
2013-12-19  7:19       ` Jagan Teki
2013-12-19  7:20         ` Sourav Poddar
2013-12-19  8:47         ` Sourav Poddar
2013-12-19  8:51           ` Jagan Teki
2013-12-19  8:58             ` Sourav Poddar
2013-12-19  9:17               ` Jagan Teki
2013-12-19  9:20               ` Jagan Teki
2013-12-19  9:23                 ` Sourav Poddar
2013-12-19 11:16                 ` Sourav Poddar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B27E8A.8090102@ti.com \
    --to=sourav.poddar@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.