From: Wang Weidong <wangweidong1@huawei.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: <wensong@linux-vs.org>, <horms@verge.net.au>,
David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] netfilter: ipvs: remove the unused variable
Date: Thu, 19 Dec 2013 16:00:29 +0800 [thread overview]
Message-ID: <52B2A79D.4060403@huawei.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1312190912090.1749@ja.home.ssi.bg>
On 2013/12/19 15:17, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 19 Dec 2013, Wang Weidong wrote:
>
>> when I built the netfilter, I got that:
>> net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
>> net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’
>
> There is another patch that we plan to apply but
> due to possible merge conflict it was delayed:
>
> http://marc.info/?t=138426695600002&r=1&w=2
> http://marc.info/?t=138426469400008&r=1&w=2
>
> May be it is time to apply it...
>
Ok, Got it.
Regards.
Wang
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
>> ---
>> net/netfilter/ipvs/ip_vs_sync.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
>> index f63c238..d258125 100644
>> --- a/net/netfilter/ipvs/ip_vs_sync.c
>> +++ b/net/netfilter/ipvs/ip_vs_sync.c
>> @@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
>> continue;
>> }
>> while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
>> - int ret = __wait_event_interruptible(*sk_sleep(sk),
>> + __wait_event_interruptible(*sk_sleep(sk),
>> sock_writeable(sk) ||
>> kthread_should_stop());
>> if (unlikely(kthread_should_stop()))
>> --
>> 1.7.12
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
next prev parent reply other threads:[~2013-12-19 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 2:23 [PATCH net-next] netfilter: ipvs: remove the unused variable Wang Weidong
2013-12-19 7:17 ` Julian Anastasov
2013-12-19 8:00 ` Wang Weidong [this message]
2013-12-27 3:21 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B2A79D.4060403@huawei.com \
--to=wangweidong1@huawei.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.