From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: [PATCH] f2fs: move all the bio initialization into __bio_alloc Date: Thu, 19 Dec 2013 17:22:18 +0800 Message-ID: <52B2BACA.80600@cn.fujitsu.com> References: <52B17905.7040708@cn.fujitsu.com> <000a01cefc59$0a9b4580$1fd1d080$@samsung.com> <1387443585.2101.216.camel@kjgkr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VtZvH-0001bn-WD for linux-f2fs-devel@lists.sourceforge.net; Thu, 19 Dec 2013 09:29:40 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1VtZvE-0003n8-Qc for linux-f2fs-devel@lists.sourceforge.net; Thu, 19 Dec 2013 09:29:39 +0000 In-Reply-To: <1387443585.2101.216.camel@kjgkr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: jaegeuk.kim@samsung.com Cc: 'fsdevel' , 'linux-kernel' , 'f2fs' SGkgS2ltLCBZdSwKVGhhbmtzIGZvciB5b3VyIHJldmlldyEKCk9uIDEyLzE5LzIwMTMgMDQ6NTkg UE0sIEphZWdldWsgS2ltIHdyb3RlOgoKPiBIaSBHdSwKPiAKPiBJIGFncmVlZCB3aXRoIENoYW8u Cj4gSXQgaXMgbW9yZSByZWFkYWJsZSB0byB1c2Ugc29tZXRoaW5nIGxpa2UgImlzX3JlYWQiIGlu c3RlYWQgb2YgInJ3Ii4KCkFncmVlLiBJJ2xsIGZvbGxvdyBpdC4KClJlZ2FyZHMsCkd1Cgo+IFRo YW5rcywKPiAKPiAyMDEzLTEyLTE5ICjrqqkpLCAwOToyMyArMDgwMCwgQ2hhbyBZdToKPj4gSGkg R3UsCj4+Cj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+Pj4gRnJvbTogR3UgWmhlbmcg W21haWx0bzpndXouZm5zdEBjbi5mdWppdHN1LmNvbV0KPj4+IFNlbnQ6IFdlZG5lc2RheSwgRGVj ZW1iZXIgMTgsIDIwMTMgNjoyOSBQTQo+Pj4gVG86IEtpbQo+Pj4gQ2M6IGZzZGV2ZWw7IGxpbnV4 LWtlcm5lbDsgZjJmcwo+Pj4gU3ViamVjdDogW2YyZnMtZGV2XSBbUEFUQ0hdIGYyZnM6IG1vdmUg YWxsIHRoZSBiaW8gaW5pdGlhbGl6YXRpb24gaW50byBfX2Jpb19hbGxvYwo+Pj4KPj4+IE1vdmUg YWxsIHRoZSBiaW8gaW5pdGlhbGl6YXRpb24gaW50byBfX2Jpb19hbGxvYywgYW5kIHNvbWUgbWlu b3IgY2xlYW51cHMgYXJlCj4+PiBhbHNvIGFkZGVkLgo+Pgo+PiBMb29rcyBtb3JlIG5lYXQhCj4+ Cj4+PiBAQCAtMTc4LDE3ICsxNzksMTYgQEAgdm9pZCBmMmZzX3N1Ym1pdF9wYWdlX21iaW8oc3Ry dWN0IGYyZnNfc2JfaW5mbyAqc2JpLCBzdHJ1Y3QgcGFnZSAqcGFnZSwKPj4+ICAJCQlibG9ja190 IGJsa19hZGRyLCBzdHJ1Y3QgZjJmc19pb19pbmZvICpmaW8pCj4+PiAgewo+Pj4gIAllbnVtIHBh Z2VfdHlwZSBidHlwZSA9IFBBR0VfVFlQRV9PRl9CSU8oZmlvLT50eXBlKTsKPj4+IC0Jc3RydWN0 IGJsb2NrX2RldmljZSAqYmRldiA9IHNiaS0+c2ItPnNfYmRldjsKPj4+ICAJc3RydWN0IGYyZnNf YmlvX2luZm8gKmlvOwo+Pj4gLQlpbnQgYmlvX2Jsb2NrczsKPj4+ICsJaW50IHJ3ID0gaXNfcmVh ZF9pbyhmaW8tPnJ3KTsKPj4KPj4gTWF5YmUgaXQncyBtb3JlIG5lYXQgdG8gdXNlICdpc19yZWFk JyB0byBpbnN0ZWFkIG9mICdydycuCj4+Cj4+IFRoYW5rcwo+Pgo+IAoKCgotLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KUmFwaWRseSB0cm91Ymxlc2hvb3QgcHJvYmxlbXMgYmVmb3JlIHRoZXkgYWZmZWN0 IHlvdXIgYnVzaW5lc3MuIE1vc3QgSVQgCm9yZ2FuaXphdGlvbnMgZG9uJ3QgaGF2ZSBhIGNsZWFy IHBpY3R1cmUgb2YgaG93IGFwcGxpY2F0aW9uIHBlcmZvcm1hbmNlIAphZmZlY3RzIHRoZWlyIHJl dmVudWUuIFdpdGggQXBwRHluYW1pY3MsIHlvdSBnZXQgMTAwJSB2aXNpYmlsaXR5IGludG8geW91 ciAKSmF2YSwuTkVULCAmIFBIUCBhcHBsaWNhdGlvbi4gU3RhcnQgeW91ciAxNS1kYXkgRlJFRSBU UklBTCBvZiBBcHBEeW5hbWljcyBQcm8hCmh0dHA6Ly9wdWJhZHMuZy5kb3VibGVjbGljay5uZXQv Z2FtcGFkL2Nsaz9pZD04NDM0OTgzMSZpdT0vNDE0MC9vc3RnLmNsa3RyawpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRldmVsIG1haWxp bmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xp c3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411Ab3LSJ3h (ORCPT ); Thu, 19 Dec 2013 04:29:37 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:4157 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752187Ab3LSJ3e convert rfc822-to-8bit (ORCPT ); Thu, 19 Dec 2013 04:29:34 -0500 X-IronPort-AV: E=Sophos;i="4.95,512,1384272000"; d="scan'208";a="9290856" Message-ID: <52B2BACA.80600@cn.fujitsu.com> Date: Thu, 19 Dec 2013 17:22:18 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: jaegeuk.kim@samsung.com CC: Chao Yu , "'fsdevel'" , "'linux-kernel'" , "'f2fs'" Subject: Re: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc References: <52B17905.7040708@cn.fujitsu.com> <000a01cefc59$0a9b4580$1fd1d080$@samsung.com> <1387443585.2101.216.camel@kjgkr> In-Reply-To: <1387443585.2101.216.camel@kjgkr> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/12/19 17:28:54, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/12/19 17:28:57 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kim, Yu, Thanks for your review! On 12/19/2013 04:59 PM, Jaegeuk Kim wrote: > Hi Gu, > > I agreed with Chao. > It is more readable to use something like "is_read" instead of "rw". Agree. I'll follow it. Regards, Gu > Thanks, > > 2013-12-19 (목), 09:23 +0800, Chao Yu: >> Hi Gu, >> >>> -----Original Message----- >>> From: Gu Zheng [mailto:guz.fnst@cn.fujitsu.com] >>> Sent: Wednesday, December 18, 2013 6:29 PM >>> To: Kim >>> Cc: fsdevel; linux-kernel; f2fs >>> Subject: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc >>> >>> Move all the bio initialization into __bio_alloc, and some minor cleanups are >>> also added. >> >> Looks more neat! >> >>> @@ -178,17 +179,16 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct page *page, >>> block_t blk_addr, struct f2fs_io_info *fio) >>> { >>> enum page_type btype = PAGE_TYPE_OF_BIO(fio->type); >>> - struct block_device *bdev = sbi->sb->s_bdev; >>> struct f2fs_bio_info *io; >>> - int bio_blocks; >>> + int rw = is_read_io(fio->rw); >> >> Maybe it's more neat to use 'is_read' to instead of 'rw'. >> >> Thanks >> >