Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 12/16/2013 08:23 AM, Andreas Färber wrote:
> Am 04.12.2013 06:51, schrieb Peter Crosthwaite:
>> On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> From: Hervé Poussineau <hpoussin@reactos.org>
>>>
>>> We should not modify the type hash table while it is being iterated on.
>>> Assert that it does not happen.
>>>
>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>  qom/object.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/qom/object.c b/qom/object.c
>>> index 3a43186..1dee9f0 100644
>>> --- a/qom/object.c
>>> +++ b/qom/object.c
>>> @@ -78,8 +78,10 @@ static GHashTable *type_table_get(void)
>>>      return type_table;
>>>  }
>>>
>>> +static bool enumerating = false;
>>
>> Global variable could probably use a more descriptive name.
> 
> I renamed it to enumerating_types and dropped the assignment as
> suggested elsewhere by Alexey (a reply here would've been nice!).

Whose reply? To what? :)

> 
> I also took the liberty of inserted a white line to make the function
> better readable.

I do not mind, this was not my stuff :)

What I wonder about is what is going to happen to the rest of what I
posted? Should I wait till this qom-next gets merged to upstream and repost
my patches for Alex Graf again? Thanks.



-- 
Alexey