From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Chao Yang <chayang@redhat.com>,
linux-mm@kvack.org, aarcange@redhat.com, mgorman@suse.de,
Veaceslav Falico <vfalico@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH] mm,numa,THP: initialize hstate for THP page size
Date: Thu, 19 Dec 2013 10:18:32 -0500 [thread overview]
Message-ID: <52B30E48.9070505@redhat.com> (raw)
In-Reply-To: <20131219102231.GE10855@dhcp22.suse.cz>
On 12/19/2013 05:22 AM, Michal Hocko wrote:
> [Adding Dave and Mel]
> copy_huge_page as hugetlb specific thing. It relies on hstate which is
> obviously not existing for THP pages. So why do we use it for thp pages
> in the first place?
>
> Mel, your "mm: numa: Add THP migration for the NUMA working set scanning
> fault case." has added check for PageTransHuge in migrate_page_copy so
> it uses the shared copy_huge_page now. Dave has already tried to fix it
> by https://lkml.org/lkml/2013/10/28/592 but this one has been dropped
> later with "to-be-updated".
>
> Dave do you have an alternative for your patch?
Gah, never mind me. This oops happened on a slightly older tree,
that did not have Dave's patch yet...
Andrew, you can drop the patch. Sorry for the noise.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Chao Yang <chayang@redhat.com>,
linux-mm@kvack.org, aarcange@redhat.com, mgorman@suse.de,
Veaceslav Falico <vfalico@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH] mm,numa,THP: initialize hstate for THP page size
Date: Thu, 19 Dec 2013 10:18:32 -0500 [thread overview]
Message-ID: <52B30E48.9070505@redhat.com> (raw)
In-Reply-To: <20131219102231.GE10855@dhcp22.suse.cz>
On 12/19/2013 05:22 AM, Michal Hocko wrote:
> [Adding Dave and Mel]
> copy_huge_page as hugetlb specific thing. It relies on hstate which is
> obviously not existing for THP pages. So why do we use it for thp pages
> in the first place?
>
> Mel, your "mm: numa: Add THP migration for the NUMA working set scanning
> fault case." has added check for PageTransHuge in migrate_page_copy so
> it uses the shared copy_huge_page now. Dave has already tried to fix it
> by https://lkml.org/lkml/2013/10/28/592 but this one has been dropped
> later with "to-be-updated".
>
> Dave do you have an alternative for your patch?
Gah, never mind me. This oops happened on a slightly older tree,
that did not have Dave's patch yet...
Andrew, you can drop the patch. Sorry for the noise.
--
All rights reversed
next prev parent reply other threads:[~2013-12-19 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 22:03 [PATCH] mm,numa,THP: initialize hstate for THP page size Rik van Riel
2013-12-18 22:03 ` Rik van Riel
2013-12-18 22:08 ` Andrew Morton
2013-12-18 22:08 ` Andrew Morton
2013-12-18 22:20 ` Rik van Riel
2013-12-18 22:20 ` Rik van Riel
2013-12-19 10:22 ` Michal Hocko
2013-12-19 10:22 ` Michal Hocko
2013-12-19 15:18 ` Rik van Riel [this message]
2013-12-19 15:18 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B30E48.9070505@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chayang@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=vfalico@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.