From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtgWe-0003Me-Iy for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:32:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtgWW-0001nO-Mm for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:32:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43591 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtgWW-0001ir-GA for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:32:32 -0500 Message-ID: <52B31F95.2030107@suse.de> Date: Thu, 19 Dec 2013 17:32:21 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1373927181-24247-1-git-send-email-imammedo@redhat.com> <1373927181-24247-7-git-send-email-imammedo@redhat.com> <52AF2F7C.3010506@redhat.com> In-Reply-To: <52AF2F7C.3010506@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Igor Mammedov , qemu-devel@nongnu.org Cc: Paolo Bonzini , Anthony Liguori , Eduardo Habkost , Vadim Rozenfeld -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 16.12.2013 17:51, schrieb Eric Blake: > On 07/15/2013 04:25 PM, Igor Mammedov wrote: >> features check, enforce, hv_relaxed and hv_vapic are treated as >> boolean set to 'on' when passed from command line, so it's not >> neccessary to handle each of them >=20 > s/neccessary/necessary/ >=20 >> separetly. Collapse them to one catch-all branch which will >> treat >=20 > s/separetly/separately/ This one I had already fixed, thanks for pointing out the other one. Andreas >=20 >> any feature in format 'foo' as boolean set to 'on'. >>=20 >> PS: Any unknown feature will be rejected by CPU property setter >> so there is no need to check for unknown feature in >> cpu_x86_parse_featurestr(), therefore it's replaced by above >> mentioned catch-all handler. >>=20 >> Signed-off-by: Igor Mammedov Reviewed-by: >> Eduardo Habkost --- >=20 - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSsx+VAAoJEPou0S0+fgE/RRwP/jy32I+CSASdk1WXiFWgWD0d 00V5JNxp2YRPGfHIOJJKSlrJnBa67DpwCq0XlbqJTf54J78DhpMQGNWUde8rlKJw JR7d0SjmEt13zhOJJVZgmuNHznw5bo0VibfWRxnZ/7xmU+ZBXhgOGnsmtCr3sAfH 351wAx+5dkRWg1zo/wuM7gkQfkL8vMVzThlNaZJeNt3xHqoH97uGBhbC2Nl9u2kP MKkqv26Fzons4GquG3eJvSXQOat2x7+uo1WTkNETWlJC+AWOzVGA0K2FSXLjQexY 2JmE4wV+6MYxAMJCqfs7QtvJOcRRFmO+Qz/DwOH62zVZL+gVfOUErzBD5ka16Bou 6kVrXuqf21lOiLLxed8WtTPjxVKcRUgBUyu9SgD7QP31DDI8f3/mGtH1r1nUaM3v WXW2yzd8yKCaxxjONeUmVT5srtgRRRUWRFmyiByoBH4l7SoYP85ycbqXHuO/jBnY Wd7Mciw1gcW29PofaUgJTFDJheLWw4xLo/z6ZysxFQrbaBFeo+u7pESigxrgYQ+c BKDofJEYPAjKLrm/r365yRgnBU6iQ6Il5qKt9Dtk6f1XeuC42txV0HrDJu+Y/8f7 XH40uVfsadRye+WodZU9/E8MUn4bo34/JMm4CoT8CbVoWltoU2gCAAqrfF9LOflR s+DEEdic7Tca4ZLPGAyg =3D4UKD -----END PGP SIGNATURE-----