All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Dave Jones <davej@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: lockdep: BUG: MAX_LOCKDEP_ENTRIES too low!
Date: Thu, 19 Dec 2013 11:51:28 -0500	[thread overview]
Message-ID: <52B32410.9050802@oracle.com> (raw)
In-Reply-To: <20131219155917.GB25771@redhat.com>

On 12/19/2013 10:59 AM, Dave Jones wrote:
> On Thu, Dec 19, 2013 at 04:51:21PM +0100, Peter Zijlstra wrote:
>   > On Thu, Dec 19, 2013 at 10:39:57AM -0500, Sasha Levin wrote:
>   > > That discusses lockdep classes, which is actually fine in my case. I ran out of
>   > > MAX_LOCKDEP_ENTRIES, which isn't mentioned anywhere in Documentation/ .
>   >
>   > Yeah, it suffers from the same problem though. Lockdep has static
>   > resource allocation and never frees them.
>   >
>   > The lock classes are the smallest pool and usually run out first, but
>   > the same could happen for the entries, after all, the more classes we
>   > have the more class connections can happen.
>   >
>   > Anyway, barring a leak and silly class mistakes like mentioned in the
>   > document there's nothing we can do except raise the number.
>
> I tried this. When you bump it to 32k, it fares better but then you
> start seeing "BUG: MAX_LOCKDEP_CHAINS too low!" instead.
> I've not tried bumping that yet, as I've stopped seeing these lately
> due to hitting more serious bugs first.

Yeah, I see what you're saying. After upping that to 32k I've hit MAX_STACK_TRACE_ENTRIES.

Going to try upping that and see how that goes.


Thanks,
Sasha

  parent reply	other threads:[~2013-12-19 16:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  5:53 lockdep: BUG: MAX_LOCKDEP_ENTRIES too low! Sasha Levin
2013-12-19 10:34 ` Peter Zijlstra
2013-12-19 14:02   ` Sasha Levin
2013-12-19 15:20     ` Peter Zijlstra
2013-12-19 15:39       ` Sasha Levin
2013-12-19 15:51         ` Peter Zijlstra
2013-12-19 15:59           ` Dave Jones
2013-12-19 16:01             ` Peter Zijlstra
2013-12-19 16:10               ` Dave Jones
2013-12-19 16:51             ` Sasha Levin [this message]
2013-12-20  4:05             ` Mike Galbraith
2013-12-19 15:49       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B32410.9050802@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.