From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VtgwG-0004Bt-3w
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:59:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vtgw7-0002ej-7d
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:59:08 -0500
Received: from mail-qe0-x235.google.com ([2607:f8b0:400d:c02::235]:65419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vtgw7-0002dp-2p
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:58:59 -0500
Received: by mail-qe0-f53.google.com with SMTP id nc12so1222648qeb.26
	for <qemu-devel@nongnu.org>; Thu, 19 Dec 2013 08:58:57 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B325C9.1090007@twiddle.net>
Date: Thu, 19 Dec 2013 08:58:49 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387293144-11554-1-git-send-email-peter.maydell@linaro.org>
	<1387293144-11554-2-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1387293144-11554-2-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/21] target-arm: A64: add support for
	ld/st pair
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/17/2013 07:12 AM, Peter Maydell wrote:
> +    TCGMemOp memop =  MO_TE + size;

Watch the double space (multiple occurrences).


> +    if (is_vector) {
> +        if (opc == 3) {
> +            unallocated_encoding(s);
> +            return;
> +        }

In the integer LDP description I see

  if L:opc<0> == '01' || opc == '11' then UnallocatedEncoding();

I think that opc == 3 check should be hoisted outside is_vector.


r~