From: Julien Grall <julien.grall@linaro.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.campbell@citrix.com,
patches@linaro.org
Subject: Re: [PATCH] tools/libx: xl uptime doesn't require argument
Date: Thu, 19 Dec 2013 17:04:55 +0000 [thread overview]
Message-ID: <52B32737.4000303@linaro.org> (raw)
In-Reply-To: <21171.9437.668231.442440@mariner.uk.xensource.com>
On 12/19/2013 04:54 PM, Ian Jackson wrote:
> Julien Grall writes ("[PATCH] tools/libx: xl uptime doesn't require argument"):
>> The current behavior is:
>>
>> 42sh> xl uptime
>> 'xl uptime' requires at least 1 argument.
>>
>> Usage: xl [-v] uptime [-s] [Domain]
>>
>> The normal behavior should list uptime for each domain when there is no
>> parameters.
>
> Maybe I'm confused, but the current code seems not to do that even if
> you change option parsing spec. Is there part of your patch missing ?
No, the last argument of SWITCH_FOREACH_OPT indicates how many argument
is required.
With this simple patch I can do:
42sh> xl uptime
Name ID Uptime
Domain-0 0 12:25:52
--
Julien Grall
next prev parent reply other threads:[~2013-12-19 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 16:45 [PATCH] tools/libx: xl uptime doesn't require argument Julien Grall
2013-12-19 16:54 ` Ian Jackson
2013-12-19 17:04 ` Julien Grall [this message]
2013-12-19 17:12 ` Ian Jackson
2014-01-09 14:53 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B32737.4000303@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.