All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH] nf-nat: don't use per destination incrementing ports in nat random mode
Date: Fri, 20 Dec 2013 00:21:15 +0100	[thread overview]
Message-ID: <52B37F6B.9010105@redhat.com> (raw)
In-Reply-To: <20131219134007.GA24118@order.stressinduktion.org>

On 12/19/2013 02:40 PM, Hannes Frederic Sowa wrote:
> Don't use per destination incrementing port allocation
> in NF_NAT_RANGE_PROTO_RANDOM mode as advised in
> <https://sites.google.com/site/hayashulman/files/NIC-derandomisation.pdf>.
>
> This is especially important for UDP/DNS.
>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

I would have liked a more elaborate commit message ;) but anyway,
lgtm, now that we also have periodic reseeding in prandom:

Reviewed-by: Daniel Borkmann <dborkman@redhat.com>

The referenced paper in section 5 is also available here:

http://arxiv.org/pdf/1205.5190v1.pdf

  reply	other threads:[~2013-12-19 23:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 13:40 [PATCH] nf-nat: don't use per destination incrementing ports in nat random mode Hannes Frederic Sowa
2013-12-19 23:21 ` Daniel Borkmann [this message]
2013-12-20  0:48   ` [PATCH next v2] " Hannes Frederic Sowa
2013-12-20  8:01     ` Pablo Neira Ayuso
2013-12-20 21:40       ` [PATCH v2 -next] netfilter: don't use per-destination " Hannes Frederic Sowa
2013-12-21 12:17         ` Pablo Neira Ayuso
2013-12-21 12:26           ` Hannes Frederic Sowa
2013-12-21 12:27             ` Pablo Neira Ayuso
2013-12-21 16:25               ` Daniel Borkmann
2013-12-22  3:15         ` [PATCH iptables] iptables: snat: add randomize-full support Hannes Frederic Sowa
2014-01-03 23:43           ` Pablo Neira Ayuso
2014-01-03 22:52         ` [PATCH v2 -next] netfilter: don't use per-destination incrementing ports in nat random mode Pablo Neira Ayuso
2014-01-03 23:11           ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B37F6B.9010105@redhat.com \
    --to=dborkman@redhat.com \
    --cc=hannes@stressinduktion.org \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.