All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nithin Nayak Sujir <nsujir@broadcom.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<stable@vger.kernel.org>, Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH net] tg3: Expand 4g_overflow_test workaround to skb fragments of any size.
Date: Thu, 19 Dec 2013 17:33:31 -0800	[thread overview]
Message-ID: <52B39E6B.1090305@broadcom.com> (raw)
In-Reply-To: <1387499933.19078.379.camel@edumazet-glaptop2.roam.corp.google.com>


>> -	return (base > 0xffffdcc0) && (base + len + 8 < base);
>> +	return (base + len + 8 < base);
>>   }
>
> And it is actually faster ;)
>
> What is 8 value exactly ?
>
>

Some older devices needed to be at least 8 bytes away from the boundary. For 
simplicity we use the same check for all devices.

  reply	other threads:[~2013-12-20  1:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20  0:24 [PATCH net] tg3: Expand 4g_overflow_test workaround to skb fragments of any size Nithin Nayak Sujir
2013-12-20  0:38 ` Eric Dumazet
2013-12-20  1:33   ` Nithin Nayak Sujir [this message]
2013-12-20  0:41 ` Eric Dumazet
2013-12-20  1:35   ` Nithin Nayak Sujir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B39E6B.1090305@broadcom.com \
    --to=nsujir@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.