From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nithin Nayak Sujir Subject: Re: [PATCH net] tg3: Expand 4g_overflow_test workaround to skb fragments of any size. Date: Thu, 19 Dec 2013 17:35:50 -0800 Message-ID: <52B39EF6.9080006@broadcom.com> References: <1387499052-7838-1-git-send-email-nsujir@broadcom.com> <1387500064.19078.381.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , Michael Chan To: Eric Dumazet Return-path: In-Reply-To: <1387500064.19078.381.camel@edumazet-glaptop2.roam.corp.google.com> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 12/19/2013 04:41 PM, Eric Dumazet wrote: > On Thu, 2013-12-19 at 16:24 -0800, Nithin Nayak Sujir wrote: >> The current driver assumes that an skb fragment can only be upto jumbo >> size. Presumably this was a fast-path optimization. This assumption is >> no longer true as fragments can be upto 32k. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Nithin Nayak Sujir >> Signed-off-by: Michael Chan >> --- >> drivers/net/ethernet/broadcom/tg3.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c >> index f3dd93b..8ab21d7 100644 >> --- a/drivers/net/ethernet/broadcom/tg3.c >> +++ b/drivers/net/ethernet/broadcom/tg3.c >> @@ -7622,7 +7622,7 @@ static inline int tg3_4g_overflow_test(dma_addr_t mapping, int len) >> { >> u32 base = (u32) mapping & 0xffffffff; >> >> - return (base > 0xffffdcc0) && (base + len + 8 < base); >> + return (base + len + 8 < base); >> } >> >> /* Test for TSO DMA buffers that cross into regions which are within MSS bytes > > btw this is also : > > return base + len + 8 < base; > > > I'll send a v2.