Re: [PATCH 1/2] ARM: tegra: modify Tegra30 USB2 default phy_type to UTMI

[Eric Brower <ebrower-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 12/18/2013 01:15 PM, Stephen Warren wrote:
> On 12/17/2013 06:52 PM, Eric Brower wrote:
>> Modify Tegra30 default USB2 phy_type to UTMI; this matches
>> power-on-reset defaults and is expected to be the common case.
>>
>> The current implementation is likely an incorrect
>> carry-over from Tegra20, where USB2 does default to ULPI.
>
>> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
>
>>   	phy2: usb-phy@7d004000 {
>>   		compatible = "nvidia,tegra30-usb-phy";
>> -		reg = <0x7d004000 0x4000>;
>> -		phy_type = "ulpi";
>> +		reg = <0x7d004000 0x4000 0x7d004000 0x4000>;
>
> Are you sure the second entry in the reg property is correct here? In
> Tegra20, the UTMI pad registers are in the USB1 (USBD) register space
> for both USB controllers, and I would guess the same applies for all 3
> controllers on Tegra30, since both USB1 and USB3 on Tegra30 already
> point this reg entry at USBD's reg space, plus you've listed USBD as the
> clock entry for utmi-pads, rather than USB2, which would be consistent
> with the reg value.
>
> Still, this patch does seem to work for me...
>

The second entry in the reg property is indeed incorrect-- I'll send a 
new version of the series.

Though each controller has UTMIP BIAS pad registers, bias pad settings 
must be configured via USB1 only; the USB2 and USB3 BIAS pad registers 
are a no-connect-- this explains why it works as-is (USB1 configures 
bias pad settings), but is not correct for the dtsi.

Thanks for the catch!
Eric