From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3() Date: Fri, 20 Dec 2013 18:20:14 +0800 Message-ID: <52B419DE.8050706@gmail.com> References: <52B2E0FA.7090805@gmail.com> <52B2E3DB.7010008@imgtec.com> <52B2F6B7.1050802@gmail.com> <52B2F8DC.8060006@imgtec.com> <52B3A0EA.9010801@gmail.com> <52B40E44.9040603@imgtec.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1x90Zi/bFIx1voB5nuCIbKGpYZew9CPzPwt3By4lxn0=; b=tU7n8t3DrKhNrtXslSHgPQP9e8z5w0NXcoGmbijk94SGkmiUkwc+bDtJbflmyk7J0F duCKGA/yrFI9DCC0yvORqTC889u/o0O3rlS2Ah2apdVFXB3RqipkdtHpDH9EnxHG2hxk tzA4SyBu+ycgxu+JPzzOwN676j0ZSTDQu9+hLzKpnofLVRV38JQPcwLPrf/0OGv3VT7i lcJVEVr4+flb9ag4XXS7e755j+4a6FhXWXzQfr7JmWJiVRJYQRXpb6bd8oz7z3AwuJmo MYk+ckHmAtXCDZLwLYoT9WVicqVsm5hFFdO8Fd5z0sszb6BB0Y8wa9X+hu4OsJy+pxAN 3soQ== In-Reply-To: <52B40E44.9040603@imgtec.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: James Hogan Cc: rostedt@goodmis.org, "linux-kernel@vger.kernel.org" , linux-metag@vger.kernel.org On 12/20/2013 05:30 PM, James Hogan wrote: > On 20/12/13 01:44, Chen Gang wrote: >> On 12/19/2013 09:47 PM, James Hogan wrote: >>> No, I believe there shouldn't be any use of the C 64bit division/modulo >>> operations in generic kernel code in the first place, so like I said >>> before the code in question should be fixed to use the proper functions >>> in . >>> >> >> OK, thanks, your idea is one of fix ways. >> >> Hmm... for me, it is still not a bad idea to add "__umoddi3" to metag. > > NAK > > Please read this: > http://yarchive.net/comp/linux/64bit_divide.html > OK, thanks, that sounds reasonable to me. For kernel, we really need treat it carefully. Hmm... but do you know why we need some 64-bit functions which are implemented under "arch/metag/lib/*.S"? can we use instead of them? (e.g 64-bit '/'). And for me, 64-bit '/' and '%' are related operations, if provide one, we also need provide the other (or neither of them are provided). Thanks. -- Chen Gang Open, share and attitude like air, water and life which God blessed