All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: rostedt@goodmis.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-metag@vger.kernel.org
Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3()
Date: Fri, 20 Dec 2013 10:48:43 +0000	[thread overview]
Message-ID: <52B4208B.1080801@imgtec.com> (raw)
In-Reply-To: <52B419DE.8050706@gmail.com>

On 20/12/13 10:20, Chen Gang wrote:
> Hmm... but do you know why we need some 64-bit functions which are
> implemented under "arch/metag/lib/*.S"? can we use <linux/math64.h>
> instead of them? (e.g 64-bit '/').

If you look at linux/math64.h you'll see it only implements division
operations. The other 64 bit operations like shift, compare, and
multiply are relatively cheap so are implemented as intrinsics instead.

Cheers
James

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: <rostedt@goodmis.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	<linux-metag@vger.kernel.org>
Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3()
Date: Fri, 20 Dec 2013 10:48:43 +0000	[thread overview]
Message-ID: <52B4208B.1080801@imgtec.com> (raw)
In-Reply-To: <52B419DE.8050706@gmail.com>

On 20/12/13 10:20, Chen Gang wrote:
> Hmm... but do you know why we need some 64-bit functions which are
> implemented under "arch/metag/lib/*.S"? can we use <linux/math64.h>
> instead of them? (e.g 64-bit '/').

If you look at linux/math64.h you'll see it only implements division
operations. The other 64 bit operations like shift, compare, and
multiply are relatively cheap so are implemented as intrinsics instead.

Cheers
James


  reply	other threads:[~2013-12-20 10:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 12:05 [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3() Chen Gang
2013-12-19 12:17 ` James Hogan
2013-12-19 12:17   ` James Hogan
2013-12-19 13:37   ` Chen Gang
2013-12-19 13:47     ` James Hogan
2013-12-19 13:47       ` James Hogan
     [not found]       ` <52B2F8DC.8060006-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2013-12-20  1:44         ` Chen Gang
2013-12-20  1:44           ` Chen Gang
2013-12-20  9:30           ` James Hogan
2013-12-20  9:30             ` James Hogan
2013-12-20 10:20             ` Chen Gang
2013-12-20 10:48               ` James Hogan [this message]
2013-12-20 10:48                 ` James Hogan
     [not found]                 ` <52B4208B.1080801-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2013-12-20 11:51                   ` Chen Gang
2013-12-20 11:51                     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B4208B.1080801@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-metag@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.