From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vty1X-0004T1-1j for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:13:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vty1R-0001mG-7c for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:13:42 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57006 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vty1R-0001m6-12 for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:13:37 -0500 Message-ID: <52B4265C.5060803@suse.de> Date: Fri, 20 Dec 2013 12:13:32 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387463413-20070-1-git-send-email-armbru@redhat.com> In-Reply-To: <1387463413-20070-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com, qemu-devel@nongnu.org Cc: Anthony Liguori , lcapitulino@redhat.com Am 19.12.2013 15:30, schrieb armbru@redhat.com: > From: Markus Armbruster >=20 > Once upon a time, the error message was: >=20 > qemu: -device nonexistant: "Device "nonexistant" not found. Try -d= evice '?' for a list. >=20 > But progress marches on, and conversion to QError (commit 0204276) > changed it into: >=20 > Invalid parameter 'driver' > Try with argument '?' for a list. >=20 > Progress didn't stop there, of course. After a couple of iterations, > we arrived at the current message (commit 6acbe4c): >=20 > qemu: -device nonexistant: Parameter 'driver' expects device type >=20 > Mission accomplished: this is complete mush. >=20 > We've since abandoned our quest for "rich" error objects, fortunately > before it turned all error messages into mush. Time to undo the > damage to this one. Make it: >=20 > qemu: -device nonexistant: nonexistant is not a valid device model = name >=20 > Signed-off-by: Markus Armbruster > --- > qdev-monitor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, rebased onto your other fix and applied to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg