From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtyUB-0000rr-4M for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:43:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtyU5-000228-4K for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:43:19 -0500 Received: from mail-pb0-f50.google.com ([209.85.160.50]:54606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtyU4-00021v-U0 for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:43:13 -0500 Received: by mail-pb0-f50.google.com with SMTP id rr13so2511940pbb.37 for ; Fri, 20 Dec 2013 03:43:11 -0800 (PST) Message-ID: <52B42D49.9060402@ozlabs.ru> Date: Fri, 20 Dec 2013 22:43:05 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1386085320-12965-1-git-send-email-pbonzini@redhat.com> <1386085320-12965-3-git-send-email-pbonzini@redhat.com> <52AE1DBB.9080605@suse.de> <52B2DAA6.5050806@ozlabs.ru> <52B429FD.3040800@suse.de> In-Reply-To: <52B429FD.3040800@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Paolo Bonzini , Peter Crosthwaite , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , "qemu-devel@nongnu.org Developers" , Igor Mammedov On 12/20/2013 10:29 PM, Andreas Färber wrote: > Am 19.12.2013 12:38, schrieb Alexey Kardashevskiy: >> On 12/16/2013 08:23 AM, Andreas Färber wrote: >>> Am 04.12.2013 06:51, schrieb Peter Crosthwaite: >>>> On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini wrote: >>>>> From: Hervé Poussineau >>>>> >>>>> We should not modify the type hash table while it is being iterated on. >>>>> Assert that it does not happen. >>>>> >>>>> Signed-off-by: Hervé Poussineau >>>>> Signed-off-by: Paolo Bonzini >>>>> --- >>>>> qom/object.c | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/qom/object.c b/qom/object.c >>>>> index 3a43186..1dee9f0 100644 >>>>> --- a/qom/object.c >>>>> +++ b/qom/object.c >>>>> @@ -78,8 +78,10 @@ static GHashTable *type_table_get(void) >>>>> return type_table; >>>>> } >>>>> >>>>> +static bool enumerating = false; >>>> >>>> Global variable could probably use a more descriptive name. >>> >>> I renamed it to enumerating_types and dropped the assignment as >>> suggested elsewhere by Alexey (a reply here would've been nice!). >> >> Whose reply? To what? :) > > A reply of yours to Peter C.'s change request, stating that you have > addressed it - and in this case in which series. :) You lost me here. I got these patches from Paolo Bonzini and I was told to repost them together with my other patches, that's it :) >>> I also took the liberty of inserted a white line to make the function >>> better readable. >> >> I do not mind, this was not my stuff :) >> >> What I wonder about is what is going to happen to the rest of what I >> posted? Should I wait till this qom-next gets merged to upstream and repost >> my patches for Alex Graf again? Thanks. > > I do intend to post a pull before Chistmas, reviewing+applying the last > no_user patch from Markus was one key ingredient for that. > > Not sure which rest exactly you're referring to? I need to review your > latest QemuOpts proposal among others. Actually I have a whole A4 page > written down with series I'm wading through. ;) I posted the "[PATCH v4 0/8] spapr: bootindex support" series which included the 2 patches you mentioned in this series, from the rest - 3 are for spapr and 3 are platform independent. -- Alexey