From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [Patch net-next] net_sched: fix a regression in tc actions Date: Fri, 20 Dec 2013 07:15:54 -0500 Message-ID: <52B434FA.8080309@mojatatu.com> References: <1387526931-21814-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , "David S. Miller" To: Cong Wang , netdev@vger.kernel.org Return-path: Received: from mail-ie0-f174.google.com ([209.85.223.174]:39456 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932130Ab3LTMP5 (ORCPT ); Fri, 20 Dec 2013 07:15:57 -0500 Received: by mail-ie0-f174.google.com with SMTP id at1so2941135iec.33 for ; Fri, 20 Dec 2013 04:15:56 -0800 (PST) In-Reply-To: <1387526931-21814-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 12/20/13 03:08, Cong Wang wrote: > This patch fixes: > 1) pass mask rather than size to tcf_hashinfo_init() > 2) the cleanup should be in reversed order in mirred_cleanup_module() > > Reported-by: Eric Dumazet > Fixes: 369ba56787d7469c0afd ("net_sched: init struct tcf_hashinfo at register time") > Cc: Eric Dumazet > Cc: David S. Miller > Signed-off-by: Cong Wang > Please Cc me - my filters will catch it faster. Signed-off-by: Jamal Hadi Salim cheers, jamal