From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [BUGFIX][PATCH 3/4] hvm_save_one: return correct data. Date: Fri, 20 Dec 2013 13:31:09 +0000 Message-ID: <52B4469D.1060102@eu.citrix.com> References: <1386809777-12898-1-git-send-email-dslutz@terremark.com> <1386809777-12898-4-git-send-email-dslutz@terremark.com> <52AB25B4020000780010D0B0@nat28.tlf.novell.com> <52ACF7CE.9030904@terremark.com> <52ADDE15.8010408@citrix.com> <52AEC522020000780010D7BE@nat28.tlf.novell.com> <52AF3D91.6000809@terremark.com> <52B0174D020000780010E015@nat28.tlf.novell.com> <52B02A0A.8@citrix.com> <52B39006.8040707@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vu0Ai-0000DP-BY for xen-devel@lists.xenproject.org; Fri, 20 Dec 2013 13:31:20 +0000 In-Reply-To: <52B39006.8040707@terremark.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , Andrew Cooper , Ian Jackson , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On 12/20/2013 12:32 AM, Don Slutz wrote: > Adding "George Dunlap" to list of people. > > George, > I think this is a bug fix that can make it into 4.4. Some how I > forgot to include you directly. Please let me know if pushing for > this is wrong. > > Bug fix is attached to: > > http://lists.xen.org/archives/html/xen-devel/2013-12/msg02412.html > > Thanks, > -Don Slutz > > On 12/17/13 05:40, Andrew Cooper wrote: >> On 17/12/13 08:20, Jan Beulich wrote: >>>>>> On 16.12.13 at 18:51, Don Slutz wrote: >>>> I feel that the attached bugfix patch is simple enough to make it >>>> into 4.4 >>>> and also be back ported to stable branches. >>> I would tend to agree on the 4.4 part of this, but afaict this is used >>> for debugging purposes only, so I'm not so sure about backporting >>> to stable branches. What is your rationale behind that request? >>> >>> Andrew, short of taking your intrusive (and not yet agreed upon) >>> rework - would you agree Don's change at least is a sufficient >>> improvement to include it irrespective of any intentions you might >>> have with this code? >>> >>> Jan >>> >> Yes - Dons' patch would appear to fix up all the corner-cases I am aware >> of in the hypercall. It looks like this should only affect xenctx. It is a bug fix, and while not a critical one, nonetheless an important one. So I agree, it should be accepted. Release-acked-by: George Dunlap