From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Chen Weilong <chenweilong@huawei.com>,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [patch ipsec-next 4/5] xfrm: fix checkpatch error
Date: Fri, 20 Dec 2013 17:50:12 +0400 [thread overview]
Message-ID: <52B44B14.5000906@cogentembedded.com> (raw)
In-Reply-To: <1387536577-11480-5-git-send-email-chenweilong@huawei.com>
Hello.
On 20-12-2013 14:49, Chen Weilong wrote:
> From: Weilong Chen <chenweilong@huawei.com>
> Fix that "else should follow close brace '}'".
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> ---
> net/xfrm/xfrm_policy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index fbc72b4..0ed4770 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -1316,8 +1316,7 @@ xfrm_tmpl_resolve_one(struct xfrm_policy *policy, const struct flowi *fl,
> error = (x->km.state == XFRM_STATE_ERROR ?
> -EINVAL : -EAGAIN);
> xfrm_state_put(x);
> - }
> - else if (error == -ESRCH)
> + } else if (error == -ESRCH)
> error = -EAGAIN;
According to CodingStyle, both branches of *if* should have {}, if one has
it. You may as well fix this.
WBR, Sergei
next prev parent reply other threads:[~2013-12-20 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 10:49 [patch ipsec-next 0/5] xfrm: fix checkpatch errors Chen Weilong
2013-12-20 10:49 ` [patch ipsec-next 1/5] xfrm: checkpatch errors with space Chen Weilong
2013-12-20 10:49 ` [patch ipsec-next 2/5] xfrm: checkpatch errors with foo * bar Chen Weilong
2013-12-20 10:49 ` [patch ipsec-next 3/5] xfrm: checkpatch erros with space prohibited Chen Weilong
2013-12-20 10:49 ` [patch ipsec-next 4/5] xfrm: fix checkpatch error Chen Weilong
2013-12-20 13:50 ` Sergei Shtylyov [this message]
2013-12-20 10:49 ` [patch ipsec-next 5/5] xfrm: checkpatch erros with inline keyword position Chen Weilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B44B14.5000906@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chenweilong@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.