From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH] ALSA: hda - Don't be too specific for conflicting boost ctl names Date: Fri, 20 Dec 2013 14:54:05 +0100 Message-ID: <52B44BFD.5060005@canonical.com> References: <1387388362-1005-1-git-send-email-tiwai@suse.de> <52B28583.3050909@canonical.com> <52B2DC85.4020901@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id E19CF265616 for ; Fri, 20 Dec 2013 14:54:05 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Raymond Yau Cc: Takashi Iwai , ALSA Development Mailing List List-Id: alsa-devel@alsa-project.org On 12/20/2013 02:36 PM, Raymond Yau wrote: > > > >>> When a boost control influences on multiple input paths, we > shouldn't > >>> pick up the name string specific to one input but rather choose > a more > >>> generic name. A problem seen often is that a single mic boost > >>> controls both internal and external mics although the driver > picks up > >>> the very first name randomly like "Internal Mic Boost". This should > >>> have been "Mic Boost", instead. > >>> > >>> This patch tries to correct that behavior: when a boost control is > >>> available, check whether it conflicts with other inputs. If it > does, > >>> use a common string ("Mic", "Line") as long as possible, or take a > >>> generic name "Input". > >> > >> Hrm. I thought today "Mic Boost" is quite common, and meaning the mic > >> boost of the non-internal mic. So I agree there is a problem - > and thank > >> you for trying to fix it - but isn't this just changing one > problem for > >> another? Now we don't know if a "Mic Boost" control controls the > >> internal mic or not. > > > > That's true, and the problem isn't new... > > I'm fine to use a different name as a boost control used for multiple > > mics, though. Spell your wish. > > If *all* inputs go through the boost, then just preferring "Capture > Boost" or "Input Boost" over "Mic Boost" would do the trick. I e, just > skip the logic that checks for all inputs being of the same type. > > > not all inputs go through the boost, > > only two mic share boost but line in, CD, aux, stereo mix don't So what is your suggestion for a better and more consistent name? -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic