From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video/logo: don't look for the logo after system boot
Date: Fri, 20 Dec 2013 15:31:34 +0000 [thread overview]
Message-ID: <52B462D6.6040304@linutronix.de> (raw)
In-Reply-To: <1387549460-18501-1-git-send-email-bigeasy@linutronix.de>
On 12/20/2013 04:27 PM, Geert Uytterhoeven wrote:
> On Fri, Dec 20, 2013 at 3:24 PM, Sebastian Andrzej Siewior
> <bigeasy@linutronix.de> wrote:
>> If the primary GPU driver has been loaded _after_ system as a module
>> then this logo memory is no longer valid.
>> Managed to crash the system by booting a box without a GPU and then
>> hotpluggin => BOOM.
>
> Which GPU driver is this?
i915.
>
> drivers/video/fbmem.c:fb_prepare_logo() has protection against this:
>
> if (info->flags & FBINFO_MISC_TILEBLITTING ||
> info->flags & FBINFO_MODULE)
> return 0;
but gpu driver is built-in. I just add PCI device at run-time. The same
thing should happen if you go to sysfs and remove the PCI device and
then do
echo 1 > /sys/bus/pci/rescan
Sebastian
next prev parent reply other threads:[~2013-12-20 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 14:24 [PATCH] video/logo: don't look for the logo after system boot Sebastian Andrzej Siewior
2013-12-20 15:27 ` Geert Uytterhoeven
2013-12-20 15:31 ` Sebastian Andrzej Siewior [this message]
2013-12-20 15:49 ` Sebastian Andrzej Siewior
2013-12-20 16:20 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B462D6.6040304@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.