From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 16/19] ASoC: tegra: Don't set unused struct snd_pcm_hardware fields Date: Fri, 20 Dec 2013 10:43:35 -0700 Message-ID: <52B481C7.2070509@wwwdotorg.org> References: <1387545625-19240-1-git-send-email-lars@metafoo.de> <1387545625-19240-16-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org (avon.wwwdotorg.org [70.85.31.133]) by alsa0.perex.cz (Postfix) with ESMTP id CA1552615E9 for ; Fri, 20 Dec 2013 18:43:39 +0100 (CET) In-Reply-To: <1387545625-19240-16-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen , Mark Brown , Liam Girdwood Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 12/20/2013 06:20 AM, Lars-Peter Clausen wrote: > The ASoC core assumes that the PCM component of the ASoC card transparently > moves data around and does not impose any restrictions on the memory layout or > the transfer speed. It ignores all fields from the snd_pcm_hardware struct for > the PCM driver that are related to this. Setting these fields in the PCM driver > might suggest otherwise though, so rather not set them. I suppose that makes sense; the data format is determined by the FIFO in the DAI/controller, not the DMA engine that's pushing the data there (unless DMA can do data conversions, though I think our HW can't?). Tested-by: Stephen Warren Acked-by: Stephen Warren