From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices
Date: Fri, 20 Dec 2013 20:56:01 +0100 [thread overview]
Message-ID: <52B4A0D1.9010503@pengutronix.de> (raw)
In-Reply-To: <20131220125236.GA26648@localhost>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On 12/20/2013 01:52 PM, Ezequiel Garcia wrote:
> On Fri, Dec 20, 2013 at 01:35:58PM +0100, Marc Kleine-Budde wrote:
>> On 12/20/2013 01:21 PM, Ezequiel Garcia wrote:
>>> OMAP's ti_hecc driver is used to support the CAN controller on many
>>> omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x).
>>> Constrain the driver to OMAP2PLUS, which is the super-set of all the
>>> other SoCs variants.
>>
>> Why not enable it for all ARM platforms to get a bigger compile coverage?
>>
>
> Hm.. Isn't the COMPILE_TEST option for getting compile coverage?
>
> If the IP is only available on OMAP SoCs, it makes sense to only allow
> building it there, but I don't really have a strong opinion.
We've replaced the depends on ARCH_* in the flexcan and at91 driver by a
depends on ARM.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2013-12-20 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 12:21 [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices Ezequiel Garcia
2013-12-20 12:21 ` Ezequiel Garcia
2013-12-20 12:35 ` Marc Kleine-Budde
2013-12-20 12:52 ` Ezequiel Garcia
2013-12-20 19:56 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B4A0D1.9010503@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.