From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH 2/2] net_sched: optimize tcf_match_indev() Date: Fri, 20 Dec 2013 15:21:20 -0500 Message-ID: <52B4A6C0.605@mojatatu.com> References: <1387503292-20078-1-git-send-email-xiyou.wangcong@gmail.com> <1387503292-20078-2-git-send-email-xiyou.wangcong@gmail.com> <1387520573.19078.424.camel@edumazet-glaptop2.roam.corp.google.com> <1387522459.19078.427.camel@edumazet-glaptop2.roam.corp.google.com> <52B434A9.9070408@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , Linux Kernel Network Developers , "David S. Miller" To: Cong Wang Return-path: Received: from mail-ig0-f179.google.com ([209.85.213.179]:55221 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754034Ab3LTUVW (ORCPT ); Fri, 20 Dec 2013 15:21:22 -0500 Received: by mail-ig0-f179.google.com with SMTP id hk11so8045503igb.0 for ; Fri, 20 Dec 2013 12:21:21 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 12/20/13 13:55, Cong Wang wrote: > On Fri, Dec 20, 2013 at 4:14 AM, Jamal Hadi Salim wrote: >> >> Very impressive catch Eric. I would have 100% caught this with testing >> (but you caught it by inspecting code!). >> A simple test that dumps all the actions of a specific type would do. >> Example in your case, Cong: >> tc actions ls action mirred >> > > Are you sure?? About 100% >It is in my test case right after David merged it, > I still don't see any bug it reports so far. > Run before your changes and after your changes and it will be obvious. cheers, jamal