All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-media@vger.kernel.org, kyungmin.park@samsung.com,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/6] V4L: s5k6a3: Add DT binding documentation
Date: Sat, 21 Dec 2013 00:17:17 +0100	[thread overview]
Message-ID: <52B4CFFD.40409@gmail.com> (raw)
In-Reply-To: <1382033211-32329-2-git-send-email-s.nawrocki@samsung.com>

On 10/17/2013 08:06 PM, Sylwester Nawrocki wrote:
> This patch adds binding documentation for the Samsung S5K6A3(YX)
> raw image sensor.
>
> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>

Hi Mauro,

Can we merge it now without a DT binding maintainer Ack ?
There was no comments for 2 months and I believe the Ack is not mandatory
for this kind of standard binding and very similar binding has been already
reviewed (for the S5K5BAF sensor).

I just updated slightly the clock/clock-names property description, so I
would post patch [1] to the mailing lists before adding it to a pull 
request.

Thanks,
Sylwester

[1] 
http://git.linuxtv.org/snawrocki/samsung.git/commitdiff/4249788ea8c9b9d9bc95cd088351e2cdda1838f6

> ---
> Changes since v2:
>   - added AF regulator supply.
> ---
>   .../devicetree/bindings/media/samsung-s5k6a3.txt   |   32 ++++++++++++++++++++
>   1 file changed, 32 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/samsung-s5k6a3.txt
>
> diff --git a/Documentation/devicetree/bindings/media/samsung-s5k6a3.txt b/Documentation/devicetree/bindings/media/samsung-s5k6a3.txt
> new file mode 100644
> index 0000000..3806e77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/samsung-s5k6a3.txt
> @@ -0,0 +1,32 @@
> +Samsung S5K6A3(YX) raw image sensor
> +---------------------------------
> +
> +S5K6A3(YX) is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
> +and CCI (I2C compatible) control bus.
> +
> +Required properties:
> +
> +- compatible	: "samsung,s5k6a3";
> +- reg		: I2C slave address of the sensor;
> +- svdda-supply	: core voltage supply;
> +- svddio-supply	: I/O voltage supply;
> +- afvdd-supply	: AF (actuator) voltage supply;
> +- gpios		: specifier of a GPIO connected to the RESET pin;
> +- clocks	: should contain the sensor's EXTCLK clock specifier,
> +		  from common clock bindings;
> +- clock-names	: should contain "extclk" entry;
> +
> +Optional properties:
> +
> +- clock-frequency : the frequency at which the "extclk" clock should be
> +		    configured to operate, in Hz; if this property is not
> +		    specified default 24 MHz value will be used.
> +
> +The common video interfaces bindings (see video-interfaces.txt) should be
> +used to specify link to the image data receiver. The S5K6A3(YX) device
> +node should contain one 'port' child node with an 'endpoint' subnode.
> +
> +Following properties are valid for the endpoint node:
> +
> +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in
> +  video-interfaces.txt.  The sensor supports only one data lane.

  reply	other threads:[~2013-12-20 23:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 18:06 [PATCH v3 0/6] Add device tree support for Exynos4 SoC camera subsystem Sylwester Nawrocki
2013-10-17 18:06 ` [PATCH v3 1/6] V4L: s5k6a3: Add DT binding documentation Sylwester Nawrocki
2013-12-20 23:17   ` Sylwester Nawrocki [this message]
2013-10-17 18:06 ` [PATCH v3 2/6] V4L: Add driver for s5k6a3 image sensor Sylwester Nawrocki
2013-10-17 18:42   ` [PATCH v4 " Sylwester Nawrocki
2013-10-17 18:06 ` [PATCH v3 3/6] V4L: s5c73m3: Add device tree support Sylwester Nawrocki
2013-10-17 18:06 ` [PATCH v3 4/6] exynos4-is: Add clock provider for the external clocks Sylwester Nawrocki
2014-01-02 19:58   ` Mauro Carvalho Chehab
2014-01-07 21:23     ` Sylwester Nawrocki
2014-01-07 21:23       ` Sylwester Nawrocki
2013-10-17 18:06 ` [PATCH v3 5/6] exynos4-is: Use external s5k6a3 sensor driver Sylwester Nawrocki
2013-10-17 18:06 ` [PATCH v3 6/6] exynos4-is: Add support for asynchronous subdevices registration Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B4CFFD.40409@gmail.com \
    --to=sylvester.nawrocki@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.