From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: sfeldma@cumulusnetworks.com, vyasevich@gmail.com,
nhorman@tuxdriver.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>
Subject: Re: [PATCH net-next] sctp: fix missing include file
Date: Sat, 21 Dec 2013 09:44:30 +0000 [thread overview]
Message-ID: <52B562FE.4000207@redhat.com> (raw)
In-Reply-To: <20131221.000055.1377147691178558975.davem@davemloft.net>
On 12/21/2013 06:00 AM, David Miller wrote:
> From: Scott Feldman <sfeldma@cumulusnetworks.com>
> Date: Fri, 20 Dec 2013 18:51:10 -0800
>
>> Compile error reported by Jim Davis on netdev.
>>
>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>
>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>
> Applied, thanks.
Sorry for the late reply as I'm on travel with limited connectivity.
Scott, this fix is not correct, and probably should be reverted. The
correct one was already in patchwork under [1]. In SCTP, we have
net/sctp/ipv6.c for all IPv6 related functions. Also there, this
include file is already present.
Thanks !
[1] http://patchwork.ozlabs.org/patch/303308/
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: sfeldma@cumulusnetworks.com, vyasevich@gmail.com,
nhorman@tuxdriver.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>
Subject: Re: [PATCH net-next] sctp: fix missing include file
Date: Sat, 21 Dec 2013 10:44:30 +0100 [thread overview]
Message-ID: <52B562FE.4000207@redhat.com> (raw)
In-Reply-To: <20131221.000055.1377147691178558975.davem@davemloft.net>
On 12/21/2013 06:00 AM, David Miller wrote:
> From: Scott Feldman <sfeldma@cumulusnetworks.com>
> Date: Fri, 20 Dec 2013 18:51:10 -0800
>
>> Compile error reported by Jim Davis on netdev.
>>
>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>
>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>
> Applied, thanks.
Sorry for the late reply as I'm on travel with limited connectivity.
Scott, this fix is not correct, and probably should be reverted. The
correct one was already in patchwork under [1]. In SCTP, we have
net/sctp/ipv6.c for all IPv6 related functions. Also there, this
include file is already present.
Thanks !
[1] http://patchwork.ozlabs.org/patch/303308/
next prev parent reply other threads:[~2013-12-21 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 2:51 [PATCH net-next] sctp: fix missing include file Scott Feldman
2013-12-21 5:00 ` David Miller
2013-12-21 9:44 ` Daniel Borkmann [this message]
2013-12-21 9:44 ` Daniel Borkmann
2013-12-21 15:19 ` Scott Feldman
2013-12-21 15:19 ` Scott Feldman
2013-12-22 3:01 ` David Miller
2013-12-22 3:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B562FE.4000207@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.