* [PATCH net-next] sctp: fix missing include file
@ 2013-12-21 2:51 Scott Feldman
2013-12-21 5:00 ` David Miller
0 siblings, 1 reply; 8+ messages in thread
From: Scott Feldman @ 2013-12-21 2:51 UTC (permalink / raw)
To: vyasevich, nhorman; +Cc: netdev, roopa, shm
Compile error reported by Jim Davis on netdev.
ip6_sk_accept_pmtu() needs net/ip6_route.h
Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
---
net/sctp/input.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index 042ec6c..479ee19 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -48,6 +48,7 @@
#include <linux/time.h> /* For struct timeval */
#include <linux/slab.h>
#include <net/ip.h>
+#include <net/ip6_route.h>
#include <net/icmp.h>
#include <net/snmp.h>
#include <net/sock.h>
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 2:51 [PATCH net-next] sctp: fix missing include file Scott Feldman
@ 2013-12-21 5:00 ` David Miller
2013-12-21 9:44 ` Daniel Borkmann
0 siblings, 1 reply; 8+ messages in thread
From: David Miller @ 2013-12-21 5:00 UTC (permalink / raw)
To: sfeldma; +Cc: vyasevich, nhorman, netdev, roopa, shm
From: Scott Feldman <sfeldma@cumulusnetworks.com>
Date: Fri, 20 Dec 2013 18:51:10 -0800
> Compile error reported by Jim Davis on netdev.
>
> ip6_sk_accept_pmtu() needs net/ip6_route.h
>
> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 5:00 ` David Miller
@ 2013-12-21 9:44 ` Daniel Borkmann
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Borkmann @ 2013-12-21 9:44 UTC (permalink / raw)
To: David Miller
Cc: sfeldma, vyasevich, nhorman, netdev, roopa, shm,
Hannes Frederic Sowa, linux-sctp@vger.kernel.org
On 12/21/2013 06:00 AM, David Miller wrote:
> From: Scott Feldman <sfeldma@cumulusnetworks.com>
> Date: Fri, 20 Dec 2013 18:51:10 -0800
>
>> Compile error reported by Jim Davis on netdev.
>>
>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>
>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>
> Applied, thanks.
Sorry for the late reply as I'm on travel with limited connectivity.
Scott, this fix is not correct, and probably should be reverted. The
correct one was already in patchwork under [1]. In SCTP, we have
net/sctp/ipv6.c for all IPv6 related functions. Also there, this
include file is already present.
Thanks !
[1] http://patchwork.ozlabs.org/patch/303308/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
@ 2013-12-21 9:44 ` Daniel Borkmann
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Borkmann @ 2013-12-21 9:44 UTC (permalink / raw)
To: David Miller
Cc: sfeldma, vyasevich, nhorman, netdev, roopa, shm,
Hannes Frederic Sowa, linux-sctp@vger.kernel.org
On 12/21/2013 06:00 AM, David Miller wrote:
> From: Scott Feldman <sfeldma@cumulusnetworks.com>
> Date: Fri, 20 Dec 2013 18:51:10 -0800
>
>> Compile error reported by Jim Davis on netdev.
>>
>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>
>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>
> Applied, thanks.
Sorry for the late reply as I'm on travel with limited connectivity.
Scott, this fix is not correct, and probably should be reverted. The
correct one was already in patchwork under [1]. In SCTP, we have
net/sctp/ipv6.c for all IPv6 related functions. Also there, this
include file is already present.
Thanks !
[1] http://patchwork.ozlabs.org/patch/303308/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 9:44 ` Daniel Borkmann
@ 2013-12-21 15:19 ` Scott Feldman
-1 siblings, 0 replies; 8+ messages in thread
From: Scott Feldman @ 2013-12-21 15:19 UTC (permalink / raw)
To: Daniel Borkmann
Cc: David Miller, vyasevich, nhorman, Netdev, Roopa Prabhu,
Shrijeet Mukherjee, Hannes Frederic Sowa,
linux-sctp@vger.kernel.org
On Dec 21, 2013, at 1:44 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
> On 12/21/2013 06:00 AM, David Miller wrote:
>> From: Scott Feldman <sfeldma@cumulusnetworks.com>
>> Date: Fri, 20 Dec 2013 18:51:10 -0800
>>
>>> Compile error reported by Jim Davis on netdev.
>>>
>>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>>
>>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>>
>> Applied, thanks.
>
> Sorry for the late reply as I'm on travel with limited connectivity.
>
> Scott, this fix is not correct, and probably should be reverted. The
> correct one was already in patchwork under [1]. In SCTP, we have
> net/sctp/ipv6.c for all IPv6 related functions. Also there, this
> include file is already present.
>
> Thanks !
>
> [1] http://patchwork.ozlabs.org/patch/303308/
Oops, sorry, two ships passing, etc. I should have looked under patchwork first.
David, please revert my change ac0917f2 pending Daniel’s fix.
-scott
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
@ 2013-12-21 15:19 ` Scott Feldman
0 siblings, 0 replies; 8+ messages in thread
From: Scott Feldman @ 2013-12-21 15:19 UTC (permalink / raw)
To: Daniel Borkmann
Cc: David Miller, vyasevich, nhorman, Netdev, Roopa Prabhu,
Shrijeet Mukherjee, Hannes Frederic Sowa,
linux-sctp@vger.kernel.org
On Dec 21, 2013, at 1:44 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
> On 12/21/2013 06:00 AM, David Miller wrote:
>> From: Scott Feldman <sfeldma@cumulusnetworks.com>
>> Date: Fri, 20 Dec 2013 18:51:10 -0800
>>
>>> Compile error reported by Jim Davis on netdev.
>>>
>>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>>
>>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>>
>> Applied, thanks.
>
> Sorry for the late reply as I'm on travel with limited connectivity.
>
> Scott, this fix is not correct, and probably should be reverted. The
> correct one was already in patchwork under [1]. In SCTP, we have
> net/sctp/ipv6.c for all IPv6 related functions. Also there, this
> include file is already present.
>
> Thanks !
>
> [1] http://patchwork.ozlabs.org/patch/303308/
Oops, sorry, two ships passing, etc. I should have looked under patchwork first.
David, please revert my change ac0917f2 pending Daniel’s fix.
-scott
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
2013-12-21 15:19 ` Scott Feldman
@ 2013-12-22 3:01 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2013-12-22 3:01 UTC (permalink / raw)
To: sfeldma
Cc: dborkman, vyasevich, nhorman, netdev, roopa, shm, hannes,
linux-sctp
RnJvbTogU2NvdHQgRmVsZG1hbiA8c2ZlbGRtYUBjdW11bHVzbmV0d29ya3MuY29tPg0KRGF0ZTog
U2F0LCAyMSBEZWMgMjAxMyAwNzoxOTowMyAtMDgwMA0KDQo+IA0KPiBPbiBEZWMgMjEsIDIwMTMs
IGF0IDE6NDQgQU0sIERhbmllbCBCb3JrbWFubiA8ZGJvcmttYW5AcmVkaGF0LmNvbT4gd3JvdGU6
DQo+IA0KPj4gT24gMTIvMjEvMjAxMyAwNjowMCBBTSwgRGF2aWQgTWlsbGVyIHdyb3RlOg0KPj4+
IEZyb206IFNjb3R0IEZlbGRtYW4gPHNmZWxkbWFAY3VtdWx1c25ldHdvcmtzLmNvbT4NCj4+PiBE
YXRlOiBGcmksIDIwIERlYyAyMDEzIDE4OjUxOjEwIC0wODAwDQo+Pj4gDQo+Pj4+IENvbXBpbGUg
ZXJyb3IgcmVwb3J0ZWQgYnkgSmltIERhdmlzIG9uIG5ldGRldi4NCj4+Pj4gDQo+Pj4+IGlwNl9z
a19hY2NlcHRfcG10dSgpIG5lZWRzIG5ldC9pcDZfcm91dGUuaA0KPj4+PiANCj4+Pj4gU2lnbmVk
LW9mZi1ieTogU2NvdHQgRmVsZG1hbiA8c2ZlbGRtYUBjdW11bHVzbmV0d29ya3MuY29tPg0KPj4+
IA0KPj4+IEFwcGxpZWQsIHRoYW5rcy4NCj4+IA0KPj4gU29ycnkgZm9yIHRoZSBsYXRlIHJlcGx5
IGFzIEknbSBvbiB0cmF2ZWwgd2l0aCBsaW1pdGVkIGNvbm5lY3Rpdml0eS4NCj4+IA0KPj4gU2Nv
dHQsIHRoaXMgZml4IGlzIG5vdCBjb3JyZWN0LCBhbmQgcHJvYmFibHkgc2hvdWxkIGJlIHJldmVy
dGVkLiBUaGUNCj4+IGNvcnJlY3Qgb25lIHdhcyBhbHJlYWR5IGluIHBhdGNod29yayB1bmRlciBb
MV0uIEluIFNDVFAsIHdlIGhhdmUNCj4+IG5ldC9zY3RwL2lwdjYuYyBmb3IgYWxsIElQdjYgcmVs
YXRlZCBmdW5jdGlvbnMuIEFsc28gdGhlcmUsIHRoaXMNCj4+IGluY2x1ZGUgZmlsZSBpcyBhbHJl
YWR5IHByZXNlbnQuDQo+PiANCj4+IFRoYW5rcyAhDQo+PiANCj4+IFsxXSBodHRwOi8vcGF0Y2h3
b3JrLm96bGFicy5vcmcvcGF0Y2gvMzAzMzA4Lw0KPiANCj4gT29wcywgc29ycnksIHR3byBzaGlw
cyBwYXNzaW5nLCBldGMuICBJIHNob3VsZCBoYXZlIGxvb2tlZCB1bmRlciBwYXRjaHdvcmsgZmly
c3QuDQo+IA0KPiBEYXZpZCwgcGxlYXNlIHJldmVydCBteSBjaGFuZ2UgYWMwOTE3ZjIgcGVuZGlu
ZyBEYW5pZWyicyBmaXguDQoNCkRvbmUuDQo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next] sctp: fix missing include file
@ 2013-12-22 3:01 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2013-12-22 3:01 UTC (permalink / raw)
To: sfeldma
Cc: dborkman, vyasevich, nhorman, netdev, roopa, shm, hannes,
linux-sctp
From: Scott Feldman <sfeldma@cumulusnetworks.com>
Date: Sat, 21 Dec 2013 07:19:03 -0800
>
> On Dec 21, 2013, at 1:44 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
>
>> On 12/21/2013 06:00 AM, David Miller wrote:
>>> From: Scott Feldman <sfeldma@cumulusnetworks.com>
>>> Date: Fri, 20 Dec 2013 18:51:10 -0800
>>>
>>>> Compile error reported by Jim Davis on netdev.
>>>>
>>>> ip6_sk_accept_pmtu() needs net/ip6_route.h
>>>>
>>>> Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
>>>
>>> Applied, thanks.
>>
>> Sorry for the late reply as I'm on travel with limited connectivity.
>>
>> Scott, this fix is not correct, and probably should be reverted. The
>> correct one was already in patchwork under [1]. In SCTP, we have
>> net/sctp/ipv6.c for all IPv6 related functions. Also there, this
>> include file is already present.
>>
>> Thanks !
>>
>> [1] http://patchwork.ozlabs.org/patch/303308/
>
> Oops, sorry, two ships passing, etc. I should have looked under patchwork first.
>
> David, please revert my change ac0917f2 pending Daniel’s fix.
Done.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-12-22 3:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 2:51 [PATCH net-next] sctp: fix missing include file Scott Feldman
2013-12-21 5:00 ` David Miller
2013-12-21 9:44 ` Daniel Borkmann
2013-12-21 9:44 ` Daniel Borkmann
2013-12-21 15:19 ` Scott Feldman
2013-12-21 15:19 ` Scott Feldman
2013-12-22 3:01 ` David Miller
2013-12-22 3:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.