Re: [PATCH for-next 2/9] IB/usnic: Fix format not a string literal warnings

[Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>]

On 12/17/13 17:48, Upinder Malhi wrote:
> Few printks in usnic are called w/o a string literal.
> Intel GCC is throwing warnings and this patch provides a fix
> for these.
> 
> [ ... ]
> @@ -372,8 +372,7 @@ static void usnic_ib_undiscover_pf(struct kref *kref)
>  		}
>  	}
> 
> -	if (!found)
> -		WARN("Failed to remove PF %s\n", pci_name(dev));
> +	WARN(found, "Failed to remove PF %s\n", pci_name(dev));
> 
>  	mutex_unlock(&usnic_ib_ibdev_list_lock);
>  }

The old code printed a warning if found == 0. The new code prints a
warning if found != 0. If this is on purpose I think this change should
be in a separate patch.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html