From: "Javier Muñoz" <jmunhoz@igalia.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Huewe <peterhuewe@gmx.de>,
Martin Berglund <martin@rogsta.net>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
devel@driverdev.osuosl.org, josh@joshtriplett.org
Subject: Re: [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c
Date: Sat, 21 Dec 2013 13:26:57 +0100 [thread overview]
Message-ID: <52B58911.30707@igalia.com> (raw)
In-Reply-To: <20131221101413.GA2946@rashika>
On 12/21/2013 11:14 AM, Rashika Kheria wrote:
> Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not
> used outside this file.
>
> This eliminates the following warning in sm7xxfb.c:
> drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Javier M. Mellid <jmunhoz@igalia.com>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index ba199ff..f08b216 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
> }
> }
>
> -void smtcfb_setmode(struct smtcfb_info *sfb)
> +static void smtcfb_setmode(struct smtcfb_info *sfb)
> {
> switch (sfb->fb.var.bits_per_pixel) {
> case 32:
>
prev parent reply other threads:[~2013-12-21 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 10:14 [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c Rashika Kheria
2013-12-21 10:26 ` Josh Triplett
2013-12-21 12:26 ` Javier Muñoz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B58911.30707@igalia.com \
--to=jmunhoz@igalia.com \
--cc=devel@driverdev.osuosl.org \
--cc=ebru.akagunduz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@rogsta.net \
--cc=peterhuewe@gmx.de \
--cc=rashika.kheria@gmail.com \
--cc=teddy.wang@siliconmotion.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.