From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
netdev@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
Date: Sat, 21 Dec 2013 22:32:01 +0100 [thread overview]
Message-ID: <52B608D1.2030105@pengutronix.de> (raw)
In-Reply-To: <52B6134C.5080301@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On 12/21/2013 11:16 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/22/2013 12:06 AM, Marc Kleine-Budde wrote:
>
>>>>> OMAP's ti_hecc driver is used to support the CAN controller on many
>>>>> omap2plus
>>>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to
>>>>> make this
>>>>> depend on OMAP3 only. Take an extra step, to get wider build
>>>>> coverage, and make
>>>>> the driver depend on ARM.
>
>>>> To have a real wide coverage, it's probably worth adding '||
>>>> COMIPLE_TEXT'
>>>> to 'depends on ARCH_OMAP2PLUS'?
>
>>> Yup, and that was my exact proposal on my reply to v1 (which I forgot
>>> to detail
>>> in v2). I'd say it's Marc's call.
>
>> Convinced, I've added the v1 of this patch to can-next together with a
>> || COMIPLE_TEXT.
>
> Sorry, I meant COMPILE_TEST, of course. :-<
lol, I copy/pasted the || COMIPLE_TEXT from you, but in the patch I
added the correct COMPILE_TEST:
- depends on ARCH_OMAP3
+ depends on ARCH_OMAP2PLUS || COMPILE_TEST
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2013-12-21 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 20:14 [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency Ezequiel Garcia
2013-12-20 20:14 ` Ezequiel Garcia
2013-12-20 21:17 ` Sergei Shtylyov
2013-12-20 21:33 ` Ezequiel Garcia
2013-12-21 21:06 ` Marc Kleine-Budde
2013-12-21 22:16 ` Sergei Shtylyov
2013-12-21 21:32 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B608D1.2030105@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.