From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VuhFp-00067O-Ml for mharc-grub-devel@gnu.org; Sun, 22 Dec 2013 06:31:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuhFi-00066O-DL for grub-devel@gnu.org; Sun, 22 Dec 2013 06:31:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VuhFd-00017y-1Q for grub-devel@gnu.org; Sun, 22 Dec 2013 06:31:22 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:37409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuhFc-00017t-Oa for grub-devel@gnu.org; Sun, 22 Dec 2013 06:31:16 -0500 Received: by mail-ea0-f180.google.com with SMTP id f15so1854300eak.39 for ; Sun, 22 Dec 2013 03:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=P0Q/5lQxQ3AZSQaQhEXPntaGsYOVdMEFaejfJSWtwIw=; b=tZAQeb/ZaeHshQU8cKTSoBeIPj4pR1+3XWXJSXZ5dXHFwLQdNXDcelxuAfSLnpUy1G Wqx8iOWWFxxcbwZSiMjk0p/Jr/xXfI3VlrGoyAGtBCDZOv65Xii0bqxIEot6SjFAyNdU MMA5yMuBeD7IxoMyPjLuxUsewgUiYEfFN7oqZrpVjXYqoxDWyYDF8Cnmng91lWGp1eej e18hD/Lfz1QQAGJJtSpRhILeEe9++fs8JxzwjLSYKJElby4/xZhnioS83fUahu9s2C0+ RmaPWWZ/bXEKLkt6GZqVNIdZwfYqsAZU1uQbgmbnN9jG1+Nmf2VPbZ/GTdScStR5eki1 YmXg== X-Received: by 10.14.199.197 with SMTP id x45mr15812215een.8.1387711875881; Sun, 22 Dec 2013 03:31:15 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id v7sm35660690eel.2.2013.12.22.03.31.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Dec 2013 03:31:14 -0800 (PST) Message-ID: <52B6CD81.3090807@gmail.com> Date: Sun, 22 Dec 2013 12:31:13 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: please attempt to minimize string changes References: <1387665282.17387.62428913.56FD8AA4@webmail.messagingengine.com> <52B62A82.1010500@gmail.com> <1387688151.918.19.camel@opensuse.site> In-Reply-To: <1387688151.918.19.camel@opensuse.site> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0JLBA2xD467IOH6EVq6KC1h3QN42LVRfI" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 Cc: Andrey Borzenkov , Benno Schulenberg X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Dec 2013 11:31:27 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0JLBA2xD467IOH6EVq6KC1h3QN42LVRfI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 22.12.2013 05:55, Andrey Borzenkov wrote: > =D0=92 =D0=92=D1=81, 22/12/2013 =D0=B2 00:55 +0100, Vladimir '=CF=86-co= der/phcoder' Serbinenko > =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> >>> While updating the Dutch translations of grub's messages, I notice th= at >>> some strings have changed in unnecessary ways. The change that makes= >>> me write this mail is the one in util/grub-mkrescue.c, lines 215-217.= >>> Those three lines were gettextized separately, which was very well, >>> because they are separate paragrahs. Now they are a single string, >>> which is not only unwieldy, and ungraspable in one view, but also eve= ry >>> translator has to concatenate her three previous separate translation= s >>> into a single one. Unneeded work. Please gettextize those paragraph= s >>> again separately, so the translations need to be tweaked only slightl= y. >>> >> grub-mkrescue was rewritten in C and current segmentation is imposed b= y >> argp. I don't know if there is a way to put old strings there. >> Perhaps someone more familiar with srgp could help? >=20 > Will below patch help? It also removes trailing dot on the first > paragraph which was not present before. Compile tested. >=20 >>> >>> By the way, in grub-core/commands/terminal.c, couldn't >>> "[--append|--remove] [TERMINAL1] [TERMINAL2] ..." >>> simply be: >>> "[--append|--remove] [TERMINAL...]"? >>> >> I find second less clear since it's more difficult to guess that the >> "..." stands for ("[TERMINAL3]",...) >> >=20 > I usually use [TERMINAL ...] (with extra spaces). I find it established= > enough practice at least in UNIX manuals. >=20 > From: Andrey Borzenkov > Subject: [PATCH] split grub-mkresecue help text to keep existing transl= ations >=20 > Reported by Benno Schulenberg >=20 > --- > util/grub-mkrescue.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > index ad45f9c..635ae63 100644 > --- a/util/grub-mkrescue.c > +++ b/util/grub-mkrescue.c > @@ -218,9 +218,9 @@ struct argp argp =3D { > N_("Make GRUB CD-ROM, disk, pendrive and floppy bootable image.")"\v= " > N_("Generates a bootable CD/USB/floppy image. Arguments other than = options to this program" > " are passed to xorriso, and indicate source files, source direct= ories, or any of the " > - "mkisofs options listed by the output of `%s'.\n\n" > - "Option -- switches to native xorriso command mode.\n\n" > - "Mail xorriso support requests to ."),=20 > + "mkisofs options listed by the output of `%s'\n") "\n" > + N_("Option -- switches to native xorriso command mode.") "\n\n" > + N_("Mail xorriso support requests to ."),=20 N_ is not a function, it only marks string for translation for gettext. argp will see the whole string with no indication how N_ was used. It will resplit the string at \v and pass both halves to gettext which will fail to find the second half in the catalog > NULL, help_filter, NULL > }; > =20 >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --0JLBA2xD467IOH6EVq6KC1h3QN42LVRfI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlK2zYEACgkQmBXlbbo5nOtuWQEArAFyNE3WQ3F+eTnRymNjPt3V G3CvJnkZh/5VWbUSG0oA/3ZWNeDKCVH/zzG8SHpesleS3lgBFq3gWjpmhKWRzASF =1dQ0 -----END PGP SIGNATURE----- --0JLBA2xD467IOH6EVq6KC1h3QN42LVRfI--