From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: mvebu: fix register length for Armada XP PMSU
Date: Mon, 23 Dec 2013 09:52:52 +0100 [thread overview]
Message-ID: <52B7F9E4.10301@free-electrons.com> (raw)
In-Reply-To: <1387788491-3168-3-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas, Jason, Sebastian, Andrew,
On 23/12/2013 09:48, Thomas Petazzoni wrote:
> The per-CPU PMSU registers documented in the datasheet start at
> 0x22100 and the last register for CPU3 is at 0x22428. However, the DT
> informations use <0x22100 0x430>, which makes the region end at
> 0x22530 and not 0x22430.
>
> Moreover, looking at the datasheet, we can see that the registers for
> CPU0 start at 0x22100, for CPU1 at 0x22200, for CPU2 at 0x22300 and
> for CPU3 at 0x22400. It seems clear that 0x100 bytes of registers have
> been used per CPU.
>
> Therefore, this commit reduces the length of the PMSU per-CPU register
> area from the incorrect 0x430 bytes to a more logical 0x400 bytes.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-xp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
> index 281c644..aa49f17 100644
> --- a/arch/arm/boot/dts/armada-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-xp.dtsi
> @@ -48,7 +48,7 @@
>
> armada-370-xp-pmsu at 22000 {
> compatible = "marvell,armada-370-xp-pmsu";
> - reg = <0x22100 0x430>, <0x20800 0x20>;
> + reg = <0x22100 0x400>, <0x20800 0x20>;
> };
>
> serial at 12200 {
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-12-23 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 8:48 [PATCH 0/3] ARM: mvebu: minor improvements Thomas Petazzoni
2013-12-23 8:48 ` [PATCH 1/3] ARM: mvebu: move ARMADA_XP_MAX_CPUS to armada-370-xp.h Thomas Petazzoni
2013-12-23 8:52 ` Gregory CLEMENT
2013-12-25 1:51 ` Jason Cooper
2013-12-23 8:48 ` [PATCH 2/3] ARM: mvebu: fix register length for Armada XP PMSU Thomas Petazzoni
2013-12-23 8:52 ` Gregory CLEMENT [this message]
2013-12-25 1:58 ` Jason Cooper
2013-12-23 8:48 ` [PATCH 3/3] ARM: mvebu: make armada_370_xp_pmsu_init() static Thomas Petazzoni
2013-12-23 8:53 ` Gregory CLEMENT
2013-12-25 1:47 ` Jason Cooper
2013-12-23 16:13 ` [PATCH 0/3] ARM: mvebu: minor improvements Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B7F9E4.10301@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.