From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:36171 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab3LWOZ6 (ORCPT ); Mon, 23 Dec 2013 09:25:58 -0500 Message-ID: <52B8452F.4070508@gmail.com> (sfid-20131223_152630_474942_9CFC31A8) Date: Mon, 23 Dec 2013 22:14:07 +0800 From: Ding Tianhong MIME-Version: 1.0 To: Felix Fietkau , Ding Tianhong , "John W. Linville" , linux-wireless@vger.kernel.org, Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 19/21] wireless: slight optimization of addr compare References: <52B7C600.8030907@huawei.com> <52B83EE1.4040705@openwrt.org> In-Reply-To: <52B83EE1.4040705@openwrt.org> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 于 2013/12/23 21:47, Felix Fietkau 写道: > On 2013-12-23 06:11, Ding Tianhong wrote: >> Use the recently added and possibly more efficient >> ether_addr_equal_unaligned to instead of memcmp. > It looks to me like all of these (including the ones in the other > similar patches) are in places, where the address data is aligned to at > least 16 bit. Because of this, using ether_addr_equal instead of > ether_addr_equal_unaligned would be much better for platforms without > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. > > - Felix Yes, the most of the place should use ether_addr_equal. thanks. Regards Ding > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ding Tianhong Subject: Re: [PATCH 19/21] wireless: slight optimization of addr compare Date: Mon, 23 Dec 2013 22:14:07 +0800 Message-ID: <52B8452F.4070508@gmail.com> References: <52B7C600.8030907@huawei.com> <52B83EE1.4040705@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE To: Felix Fietkau , Ding Tianhong , "John W. Linville" , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Netdev , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Return-path: In-Reply-To: <52B83EE1.4040705-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org =E4=BA=8E 2013/12/23 21:47, Felix Fietkau =E5=86=99=E9=81=93: > On 2013-12-23 06:11, Ding Tianhong wrote: >> Use the recently added and possibly more efficient >> ether_addr_equal_unaligned to instead of memcmp. > It looks to me like all of these (including the ones in the other > similar patches) are in places, where the address data is aligned to = at > least 16 bit. Because of this, using ether_addr_equal instead of > ether_addr_equal_unaligned would be much better for platforms without > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. >=20 > - Felix Yes, the most of the place should use ether_addr_equal. thanks. Regards Ding > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html