From mboxrd@z Thu Jan  1 00:00:00 1970
From: emilio@elopez.com.ar (=?ISO-8859-1?Q?Emilio_L=F3pez?=)
Date: Mon, 23 Dec 2013 13:44:12 -0300
Subject: [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock
 outputs
In-Reply-To: <1387787827-11341-5-git-send-email-wens@csie.org>
References: <1387787827-11341-1-git-send-email-wens@csie.org>
 <1387787827-11341-5-git-send-email-wens@csie.org>
Message-ID: <52B8685C.3060001@elopez.com.ar>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi,

El 23/12/13 05:37, Chen-Yu Tsai escribi?:
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---

Other than the lack of a commit description, the patch looks ok to me.

>   arch/arm/boot/dts/sun7i-a20.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 6ad5507..d6e7251 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -414,6 +414,20 @@
>   				allwinner,drive = <0>;
>   				allwinner,pull = <0>;
>   			};
> +
> +			clk_out_a_pins: clk_out_a {

I see the other nodes all start like

	foo_pins_a: foo0 at 0 {

Maybe yours should too? Maxime, thoughts?

> +				allwinner,pins = "PI12";
> +				allwinner,function = "clk_out_a";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
> +
> +			clk_out_b_pins: clk_out_b {
> +				allwinner,pins = "PI13";
> +				allwinner,function = "clk_out_b";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
>   		};
>
>   		timer at 01c20c00 {
>

Thanks for working on this!

Emilio