From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvBqd-0000c8-NG for qemu-devel@nongnu.org; Mon, 23 Dec 2013 15:11:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvBqZ-00007I-0D for qemu-devel@nongnu.org; Mon, 23 Dec 2013 15:11:31 -0500 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:46093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvBqY-00007C-O7 for qemu-devel@nongnu.org; Mon, 23 Dec 2013 15:11:26 -0500 Received: by mail-pd0-f182.google.com with SMTP id v10so5534417pde.27 for ; Mon, 23 Dec 2013 12:11:25 -0800 (PST) Sender: Richard Henderson Message-ID: <52B898E9.9030006@twiddle.net> Date: Mon, 23 Dec 2013 12:11:21 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1387752607-23755-1-git-send-email-peter.maydell@linaro.org> <1387752607-23755-14-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1387752607-23755-14-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 13/25] target-arm: Remove ARMCPU/CPUARMState from cpregs APIs used by decoder List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Peter Crosthwaite , patches@linaro.org, Michael Matz , Alexander Graf , Claudio Fontana , Dirk Mueller , Will Newton , Laurent Desnogues , =?ISO-8859-1?Q?Alex_Benn=E9e?= , kvmarm@lists.cs.columbia.edu, Christoffer Dall On 12/22/2013 02:49 PM, Peter Maydell wrote: > The cpregs APIs used by the decoder (get_arm_cp_reginfo() and > cp_access_ok()) currently take either a CPUARMState* or an ARMCPU*. > This is problematic for the A64 decoder, which doesn't pass the > environment pointer around everywhere the way the 32 bit decoder > does. Adjust the parameters these functions take so that we can > copy only the relevant info from the CPUARMState into the > DisasContext and then use that. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h | 6 +++--- > target-arm/helper.c | 12 ++++++------ > target-arm/translate-a64.c | 2 ++ > target-arm/translate.c | 7 ++++--- > target-arm/translate.h | 2 ++ > 5 files changed, 17 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~