From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvFiG-0003Ef-48 for qemu-devel@nongnu.org; Mon, 23 Dec 2013 19:19:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvFiA-0008MB-A0 for qemu-devel@nongnu.org; Mon, 23 Dec 2013 19:19:08 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47124 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvFiA-0008Lj-3a for qemu-devel@nongnu.org; Mon, 23 Dec 2013 19:19:02 -0500 Message-ID: <52B8D2F1.70908@suse.de> Date: Tue, 24 Dec 2013 01:18:57 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387576494-20466-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1387576494-20466-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qom: fix inherited interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, Igor Mammedov Cc: peter.crosthwaite@xilinx.com Am 20.12.2013 22:54, schrieb Paolo Bonzini: > The interface type rework had two bugs with interfaces that are inherit= ed > from a superclass. First of all, the implementation type name was wron= g > (for example it was subclass::superclass::interface rather than > just subclass::interface). Second, interfaces not registering their > type anymore means that accessing superclass::interface by type name > will fail. >=20 > This can be fixed by pre-initializing ti->parent_type of subclass::inte= rface > to superclass::interface. >=20 > Reported-by: Igor Mammedov > Tested-by: Igor Mammedov > Signed-off-by: Paolo Bonzini > --- > Andreas, perhaps this can be squashed with > 'qom: do not register interface "types" in the type table'. Thanks, I have squashed it, but I would appreciate if someone more familiar with interfaces could take a quick look at my commit message before I send a PULL tomorrow. Should I drop Reported-by during squash? https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg