Re: [PATCH 1/2] busybox: enable SEAMLESS_XZ by default

[ChenQi <Qi.Chen@windriver.com>]

On 12/24/2013 03:33 AM, Saul Wold wrote:
> On 12/23/2013 12:36 AM, Qi.Chen@windriver.com wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> We have enabled SEAMLESS_GZ and SEAMLESS_BZ2 in defconfig, it's
>> reasonable for us to enable SEAMLESS_XZ as well. Otherwise, we
>> couldn't extract tar.xz file while we could extract tar.gz file.
>> Such situation would be somewhat confusing.
>>
> It's also important to note how much bigger the busybox image grows 
> when adding a new config options, so what's the increase in # of bytes?
>

Hi Saul,

The total size increase is (511116 + 47184 - 499980 - 47184 = 11136) bytes.

Here's more data.
*) Before the change:
-rwxr-xr-x 2 chenqi chenqi 511116 Dec 23 02:44 
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.nosuid
-rwsr-xr-x 2 chenqi chenqi 47184 Dec 23 02:44 
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.suid
*) After the change:
-rwxr-xr-x 2 chenqi chenqi 499980 Dec 23 20:25 
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.nosuid
-rwsr-xr-x 2 chenqi chenqi 47184 Dec 23 20:25 
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.suid

Best Regards,
Chen Qi


> Thanks
>     Sau!
>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   meta/recipes-core/busybox/busybox/defconfig |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/busybox/busybox/defconfig 
>> b/meta/recipes-core/busybox/busybox/defconfig
>> index f0e63c2..20cd147 100644
>> --- a/meta/recipes-core/busybox/busybox/defconfig
>> +++ b/meta/recipes-core/busybox/busybox/defconfig
>> @@ -125,7 +125,7 @@ CONFIG_FEATURE_HWIB=y
>>   #
>>   # Archival Utilities
>>   #
>> -# CONFIG_FEATURE_SEAMLESS_XZ is not set
>> +CONFIG_FEATURE_SEAMLESS_XZ=y
>>   CONFIG_FEATURE_SEAMLESS_LZMA=y
>>   CONFIG_FEATURE_SEAMLESS_BZ2=y
>>   CONFIG_FEATURE_SEAMLESS_GZ=y
>>
>