From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: misplaced const Date: Tue, 24 Dec 2013 11:33:08 +0000 Message-ID: <52B970F4.4040300@linaro.org> References: <1387709997-1551-1-git-send-email-tsahee@gmx.com> <52B8059B02000078000A9C96@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52B8059B02000078000A9C96@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , tsahee@gmx.com, xen-devel@lists.xen.org Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 12/23/2013 09:42 AM, Jan Beulich wrote: >>>> 12/22/13 3:52 PM >>> >> --- a/xen/drivers/char/ns16550.c >> +++ b/xen/drivers/char/ns16550.c >> @@ -817,6 +817,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, >> static const char const *ns16550_dt_compat[] __initconst = > > This being ARM specific code, could someone please submit a patch to prevent > problems going forward with the duplicate const here (the second one really > belongs _after_ the *)? Hi Jan, Thanks for spotting the error. I noticed that every serial drivers which support Device Tree are affected by the duplicated const. I have sent a patch on the ML: https://patches.linaro.org/22744/ Cheers, -- Julien Grall