From: Ding Tianhong <dthxman@gmail.com>
To: Joe Perches <joe@perches.com>, Ding Tianhong <dingtianhong@huawei.com>
Cc: Don Fry <pcnet32@frontier.com>, Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 03/20] net: pcnet: slight optimization of addr compare
Date: Tue, 24 Dec 2013 21:47:30 +0800 [thread overview]
Message-ID: <52B99072.5070809@gmail.com> (raw)
In-Reply-To: <1387888739.2259.7.camel@joe-AO722>
于 2013/12/24 20:38, Joe Perches 写道:
> On Tue, 2013-12-24 at 19:27 +0800, Ding Tianhong wrote:
>> Use possibly more efficient ether_addr_equal_unaligned
>> to instead of memcmp.
>
> Hi again Ding.
>
>> diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
> []
>> @@ -1668,7 +1668,7 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev)
> []
>> - if (memcmp(promaddr, dev->dev_addr, ETH_ALEN) ||
>> + if (!ether_addr_equal(promaddr, dev->dev_addr) ||
>
> Can you please make sure the commit message matches the
> code changes?
>
> This uses ether_addr_equal not ether_addr_equal_unaligned.
>
> Thanks for the work.
>
Oh， no, maybe I was dizzy by these patches, I should be more careful,
sorry about that, I will resend this one.
Regards
Ding
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-12-24 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 11:27 [PATCH v2 03/20] net: pcnet: slight optimization of addr compare Ding Tianhong
2013-12-24 12:38 ` Joe Perches
2013-12-24 13:47 ` Ding Tianhong [this message]
2013-12-24 17:59 ` David Miller
2013-12-25 1:40 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B99072.5070809@gmail.com \
--to=dthxman@gmail.com \
--cc=dingtianhong@huawei.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@frontier.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.