From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvSh9-0008Ih-Ed for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvSh4-0001Mo-Kt for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:10:51 -0500 Received: from mail-pb0-x22d.google.com ([2607:f8b0:400e:c01::22d]:57469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvSh4-0001Mg-Cg for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:10:46 -0500 Received: by mail-pb0-f45.google.com with SMTP id rp16so6518492pbb.18 for ; Tue, 24 Dec 2013 06:10:45 -0800 (PST) Sender: Richard Henderson Message-ID: <52B995E1.7060409@twiddle.net> Date: Tue, 24 Dec 2013 06:10:41 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1387713039-9584-1-git-send-email-aurelien@aurel32.net> <1387713039-9584-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1387713039-9584-2-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/9] target-sh4: use bit number for SR constants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org On 12/22/2013 03:50 AM, Aurelien Jarno wrote: > Use the bit number for SR constants instead of using a bit mask. This > make possible to also use the constants for shifts. > > Signed-off-by: Aurelien Jarno > --- > target-sh4/cpu.c | 3 +- > target-sh4/cpu.h | 30 +++++++++---------- > target-sh4/gdbstub.c | 4 +-- > target-sh4/helper.c | 27 ++++++++--------- > target-sh4/op_helper.c | 26 ++++++++--------- > target-sh4/translate.c | 75 +++++++++++++++++++++++++----------------------- > 6 files changed, 85 insertions(+), 80 deletions(-) Reviewed-by: Richard Henderson r~