From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvToa-0004HS-HH
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 10:22:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvToU-0006qg-Np
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 10:22:36 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B9A6B1.7050900@twiddle.net>
Date: Tue, 24 Dec 2013 07:22:25 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387399747-4994-1-git-send-email-tommusta@gmail.com>
	<1387399747-4994-5-git-send-email-tommusta@gmail.com>
In-Reply-To: <1387399747-4994-5-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V3 PATCH 04/14] target-ppc: Add ISA2.06 divde[o]
 Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 12/18/2013 12:48 PM, Tom Musta wrote:
> +        *plow = result;
> +        *phigh = dividend % divisor;
> +        return (result > INT64_MAX) | (result < INT64_MIN);

Probably better as

  return result != *plow;

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~