From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvUVs-0004bk-5S
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 11:07:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvUVj-0003Fs-PL
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 11:07:20 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B9B12B.4060005@twiddle.net>
Date: Tue, 24 Dec 2013 08:07:07 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387399747-4994-1-git-send-email-tommusta@gmail.com>
	<1387399747-4994-13-git-send-email-tommusta@gmail.com>
In-Reply-To: <1387399747-4994-13-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V3 PATCH 12/14] target-ppc: Add ISA 2.06 ftsqrt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 12/18/2013 12:49 PM, Tom Musta wrote:
> +static void gen_ftsqrt(DisasContext *ctx)
> +{
> +    TCGv_i32 bf;
> +    if (unlikely(!ctx->fpu_enabled)) {
> +        gen_exception(ctx, POWERPC_EXCP_FPU);
> +        return;
> +    }
> +    /* NIP cannot be restored if the memory exception comes from an helper */
> +    gen_update_nip(ctx, ctx->nip - 4);
> +    bf = tcg_const_i32(crfD(ctx->opcode));
> +    gen_helper_ftsqrt(cpu_env, bf, cpu_fpr[rB(ctx->opcode)]);
> +}

Similar comments as for fdivt.


r~