Re: [PATCH] Skip Apple ghosts

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

On 24.12.2013 17:44, Andrey Borzenkov wrote:
> В Вт, 24/12/2013 в 14:26 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
> пишет:
>> Hello, all. It was discovered that on macs sometimes firmware defines
>> ghost disks with vendor suffix. E.g.
>> /ACPI(a0341d0,0)/PCI(2,1f)/UnknownMessaging(12)/EndEntire
>> is a normal disks with partitions presented with HD(...) but then
>> /ACPI(a0341d0,0)/PCI(2,1f)/UnknownMessaging(12)/MediaVendor(Apple)[0:
>> ]/EndEntire
>> is a ghost disk. It has as suffix a vendor path with empty vendor data.
> 
> Messaging subtype 12 is IPv4 Device Path. I suppose it is related to
> NetBoot.
It's hex. 0x12 is SATA.
> 
>> This is a problem because when chainloading on such disks GRUB can't
>> find handle of partition as none is defined. I propose to dkip ghosts
>> completely. This should be safe as the skip happens only for empty Apple
>> vendor suffix and if the parent is already a known disk.
> 
> Hmm ... should not we simply ignore all unknown media types? They can be
> added on case by case basis I guess.
> 
Too much breakage potential. And I don't have accessto check it on loads
of different buggy EFI systems and even if I did, it would be a waste of
time.
> diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c
> index e04203f..6dfdb0d 100644
> --- a/grub-core/disk/efi/efidisk.c
> +++ b/grub-core/disk/efi/efidisk.c
> @@ -310,6 +310,7 @@ name_devices (struct grub_efidisk_data *devices)
>               grub_efi_print_device_path (d->device_path);
>  #endif
>               /* For now, ignore the others.  */
> +             d->last_device_path = 0;
>               break;
>             }
>         }
> 
> 
>> Did anyone see anything similar?
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
> 
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]