From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/4] xfs: simplify xfs_ail_max
Date: Thu, 26 Dec 2013 18:52:33 +0800 [thread overview]
Message-ID: <52BC0A71.5010904@oracle.com> (raw)
In-Reply-To: <20131226100721.GA11950@infradead.org>
On 12/26 2013 18:07 PM, Christoph Hellwig wrote:
> On Tue, Dec 24, 2013 at 08:48:26PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> We have already simplified xfs_ail_min() with a new list helper, i.e,
>> list_first_entry_or_null(), but xfs_ail_max() still remains as same
>> as there is no corresponding list helper we can use for now. It's
>> fairly easy to simulate the list behavior of getting the last item
>> in the AIL, therefore we can simplify xfs_ail_max() and move it to
>> the header file to make this pair of AIL routines looks symmetrical.
>
> The usageof list_last_entry is fine with me, as is making it inline.
> But I think using the explicit if is a lot more readable than the ? :
> expression.
Sounds sensible to me, will take care of it.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-26 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 12:48 [PATCH 3/4] xfs: simplify xfs_ail_max Jeff Liu
2013-12-26 10:07 ` Christoph Hellwig
2013-12-26 10:52 ` Jeff Liu [this message]
2013-12-30 15:07 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC0A71.5010904@oracle.com \
--to=jeff.liu@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.